Bug 225008

Summary: Added and clarified full path names in the porter's handbook, 6.31. Shell Completion Files
Product: Documentation Reporter: Yuri Victorovich <yuri>
Component: Books & ArticlesAssignee: Sevan Janiyan <sevan>
Status: Closed FIXED    
Severity: Affects Only Me CC: carlavilla, doceng, linimon, sevan
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D16697
Attachments:
Description Flags
patch none

Description Yuri Victorovich freebsd_committer freebsd_triage 2018-01-08 17:31:22 UTC
Created attachment 189531 [details]
patch

This patch:
* Adds the completion file name for the "fish" shell
* Adds the missing second location for the "bash" shell
* Adds the file names themselves, except for "bash" where the name isn't standardized
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-01-09 05:59:57 UTC
@doceng, are you able to approve this patch?
I think, I need your approval before it can be committed.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-05 00:30:32 UTC
Sorry, wrong bug.
Comment 3 Vinícius Zavam freebsd_committer freebsd_triage 2019-04-29 10:11:54 UTC
'books/porters-handbook/shell-completion.html' still misses this patch. looks like an interesting update/patch to land.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-08-29 19:30:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=266aa8a0eae595536861939ae22aee9e4803c47d

commit 266aa8a0eae595536861939ae22aee9e4803c47d
Author:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
AuthorDate: 2023-08-29 19:27:52 +0000
Commit:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
CommitDate: 2023-08-29 19:27:52 +0000

    Porter's handbook: Added and clarified full path names

    Converted to AsciiDoc by carlavilla@

    PR:                     225008
    Differential Revision:  https://reviews.freebsd.org/D16697
    Patch by:               yuri@
    Reviewed by:            fernape@, mat@, 0mp@

 .../content/en/books/porters-handbook/special/_index.adoc   | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
Comment 5 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2023-08-29 19:56:21 UTC
Sorry for the long delay :'(