Summary: | mail/*notmuch: update to 0.26 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Sebastian Schwarz <seschwar> | ||||||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Some People | CC: | fluffy, geier, jpaetzel, misha, mp39590 | ||||||||
Priority: | --- | Flags: | seschwar:
maintainer-feedback?
(geier) seschwar: maintainer-feedback? (mp39590) |
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
URL: | https://reviews.freebsd.org/D13944 | ||||||||||
Attachments: |
|
Description
Sebastian Schwarz
2018-01-10 20:18:53 UTC
Please track situation when DESKTOP option defined without EMACS - it fails to build package, DESKTOP should imply EMACS defined --- Makefile.bak 2018-01-13 20:25:24.882256000 +1000 +++ Makefile 2018-01-13 20:24:54.689740000 +1000 @@ -71,6 +71,12 @@ RUBY_USE= RUBY=yes ZSH_CONFIGURE_WITH= zsh-completion +.include <bsd.port.options.mk> + +.if ${PORT_OPTIONS:MDESKTOP} && !${PORT_OPTIONS:MEMACS} +PORT_OPTIONS+= EMACS +.endif + do-build-MUTT-on: ${MAKE_CMD} -C ${WRKSRC}/contrib/notmuch-mutt all ${GZIP_CMD} ${WRKSRC}/contrib/notmuch-mutt/notmuch-mutt.1 (In reply to Dima Panov from comment #1) Oh, do it in Right Way™ --- Makefile.bak 2018-01-13 20:25:24.882256000 +1000 +++ Makefile 2018-01-13 20:39:34.516126000 +1000 @@ -55,6 +55,7 @@ BASH_RUN_DEPENDS= ${BASH_BUILD_DEPENDS} BASH_CONFIGURE_WITH= bash-completion DESKTOP_CONFIGURE_WITH= desktop +DESKTOP_IMPLIES= EMACS DESKTOP_USES= desktop-file-utils DOXYGEN_CONFIGURE_WITH= api-docs DOXYGEN_BUILD_DEPENDS= doxygen:devel/doxygen Created attachment 189815 [details] notmuch-0.26.diff I've performed a few more changes besides the DESKTOP_IMPLIES one and created a Phabricator revision for easier review: https://reviews.freebsd.org/D13944 Created attachment 190104 [details]
notmuch-0.26.diff
A commit references this bug: Author: fluffy Date: Tue Feb 27 05:01:30 UTC 2018 New revision: 463108 URL: https://svnweb.freebsd.org/changeset/ports/463108 Log: - Pass maintainership of mail/notmuch and mail/py-notmuch to submitter. - Update ports to version to 0.26. - Unconditionally install completions according to Porter's Handbook Chapter 6.31. without adding extra dependencies. - Turn on the MANPAGES option by default. Building the manual pages is kept as an option to allow for more minimal custom builds. - Remove RUBY option as it never did anything. There are no build or install instructions in the Makefile nor %%RUBY%% references in pkg-plist. Building with the RUBY option enabled makes absolutely no difference to the produced package. The only thing ever requiring the Ruby bindings to the Notmuch library is the Vim client, which isn't built either. - Turn mail/py-notmuch into a slave port of mail/notmuch. - Split off EMACS option into the flavor aware slave port mail/notmuch-emacs. - Split off MUTT option into the slave port mail/notmuch-mutt. - Perform miscellaneous cleanups. PR: 225059 Submitted by: seschwar AT gmail.com Reviewed by: mat, fluffy, maintainers Approved by: maintainers Differential Revision: D13944 Changes: head/mail/Makefile head/mail/notmuch/Makefile head/mail/notmuch/distinfo head/mail/notmuch/files/ head/mail/notmuch/pkg-descr head/mail/notmuch/pkg-plist head/mail/notmuch-emacs/ head/mail/notmuch-emacs/Makefile head/mail/notmuch-emacs/pkg-descr head/mail/notmuch-emacs/pkg-plist head/mail/notmuch-mutt/ head/mail/notmuch-mutt/Makefile head/mail/notmuch-mutt/pkg-descr head/mail/notmuch-mutt/pkg-plist head/mail/py-notmuch/Makefile head/mail/py-notmuch/distinfo head/mail/py-notmuch/pkg-descr |