Bug 225145

Summary: archivers/liblz4: Update to v1.8.1
Product: Ports & Packages Reporter: Martin Waschbüsch <martin>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Some People CC: swills
Priority: --- Flags: adamw: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/lz4/lz4/releases/tag/v1.8.1
Attachments:
Description Flags
Update to v1.8.1
none
poudriere testport log none

Description Martin Waschbüsch 2018-01-13 18:24:24 UTC 
Created attachment 189688 [details]
Update to v1.8.1

Updated to new stable release v1.8.1:
https://github.com/lz4/lz4/releases/tag/v1.8.1

Changes in this version detailed here:
https://github.com/lz4/lz4/blob/v1.8.1/NEWS
Comment 1 Martin Waschbüsch 2018-01-13 18:31:18 UTC 
Created attachment 189689 [details]
poudriere testport log

poudriere testport log for 11.1-RELEASE amd64
Comment 2 Martin Waschbüsch 2018-01-13 18:31:47 UTC 
QA testing:

portlint: OK
testport (11.1amd64): OK

Testport log attached.
Comment 3 Steve Wills freebsd_committer freebsd_triage 2018-01-13 22:14:17 UTC 
This fails for me:

strip: open /wrkdirs/usr/ports/archivers/liblz4/work/stage/usr/local/lib/liblz4.so.1.8.1 failed: No such file or directory
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-01-13 22:41:43 UTC 
(In reply to Steve Wills from comment #3)

Upstream forgot to update its version (lib/lz4.h). I've sent a pull request.

(In reply to Martin Waschbüsch from comment #1)

The poudriere log is wrong.

package name: liblz4-1.8.0,1
...
===> Fetching all distfiles required by liblz4-1.8.0,1 for building
=> SHA256 Checksum OK for lz4-lz4-v1.8.0_GH0.tar.gz.
Comment 5 Martin Waschbüsch 2018-01-13 22:44:31 UTC 
(In reply to Po-Chuan Hsieh from comment #4)
You are absolutely right.
I forgot to specify the dev-port when doing the poudriere testport, so it chose the default one with the current and not my updated package.
My bad!
Comment 6 Martin Waschbüsch 2018-01-13 22:45:28 UTC 
(In reply to Po-Chuan Hsieh from comment #4)
Oh and thanks for opening the upstream ticket. I appreciate it.
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-01-14 05:21:02 UTC 
Upstream managed to miss the version update in lz4.h though it's merged now.

I would add a local patch for lz4.h.
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-01-14 07:08:08 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Jan 14 07:07:40 UTC 2018
New revision: 458961
URL: https://svnweb.freebsd.org/changeset/ports/458961

Log:
  Update to 1.8.1

  Changes:	https://github.com/lz4/lz4/releases
  PR:		225145
  Submitted by:	Martin Waschbusch <martin@waschbuesch.de> (maintainer)

Changes:
  head/archivers/liblz4/Makefile
  head/archivers/liblz4/distinfo
  head/archivers/liblz4/files/
  head/archivers/liblz4/files/patch-lib-lz4.h
Comment 9 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-01-14 07:09:32 UTC 
Committed. Thanks!