Bug 225250

Summary:	FLAVORS' commit hook prevents updating devel/eric6
Product:	Ports & Packages	Reporter:	David Naylor <dbn>
Component:	Ports Framework	Assignee:	Port Management Team <portmgr>
Status:	Closed Works As Intended
Severity:	Affects Some People	CC:	adamw, ports-bugs
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description David Naylor freebsd_committer

2018-01-17 06:18:25 UTC

While trying to update devel/eric6 (which had FLAVORS added in https://reviews.freebsd.org/D13448) the commit hook complains:

Committing transaction...
svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
Do not commit a port with FLAVORS without first
getting approval from portmgr.

The commit itself does not introduce, or edit, flavors in any way.

Comment 1 David Naylor freebsd_committer

2018-01-17 06:19:57 UTC

The commit in question is ports r459220.

Comment 2 Adam Weinberger freebsd_committer

2018-01-17 13:00:23 UTC

We need to issue a portmgr blanket approval to commit updates to previously-flavoured ports.

Comment 3 Mathieu Arnold freebsd_committer

2018-01-17 14:08:27 UTC

Yes, I think I tried to allow changing a Makefile with FLAVORS in it, but I think I ended up only being able to prevent adding a new file with FLAVORS, not adding FLAVORS to a Makefile. (If that makes sense.)

Comment 4 David Naylor freebsd_committer

2018-12-11 07:06:13 UTC

I encountered this issue again.  Closing this as I just used "Approved by: portmgr (implicit)" and justified why I ignored the approval requirement.