Bug 225347

Summary: x11-toolkits/qt5-quickcontrols: some pkg-plist files wrongly marked as DEBUG
Product: Ports & Packages Reporter: Tomasz Kowalczyk <kowalczt>
Component: Individual Port(s)Assignee: freebsd-kde (group) <kde>
Status: Closed FIXED    
Severity: Affects Only Me CC: rakuco
Priority: --- Flags: rakuco: maintainer-feedback+
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
suggested change none

Description Tomasz Kowalczyk 2018-01-21 03:12:52 UTC
Created attachment 189939 [details]
suggested change

Some files are marked %%DEBUG%% in pkg-plist, but they need to be installed so plasma configure dialogs are working at all. Without them installed many windows not showing at all: for example desktop configuration window. It shows only small empty border without any content.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-01-21 11:47:08 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jan 21 11:46:48 UTC 2018
New revision: 459589
URL: https://svnweb.freebsd.org/changeset/ports/459589

Log:
  Drop %%DEBUG%% from several plist entries.

  Those items were added with %%DEBUG%% when we updated Qt to 5.3.2. At the time,
  src/dialogs/dialogs.pro had the following excerpt:

      # In case of a debug build, deploy the QML files too
      CONFIG(debug, debug|release): QML_FILES += $$DIALOGS_QML_FILES

  but that actually changed in Qt 5.9.0, which dropped the check altogether and
  always adds those files to QML_FILES.

  Not shipping them causes runtime issues according to the bug report below.

  PR:		225347
  Submitted by:	Tomasz Kowalczyk <kowalczt@zoho.eu>

Changes:
  head/x11-toolkits/qt5-quickcontrols/Makefile
  head/x11-toolkits/qt5-quickcontrols/pkg-plist
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2018-01-21 11:47:55 UTC
Thanks a lot for the patch!