Bug 225457
| Summary: | ports-mgmt/poudriere: Add DIALOG4PORTS option | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yasuhiro Kimura <yasu> | ||||||||
| Component: | Individual Port(s) | Assignee: | Bryan Drewery <bdrewery> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | bdrewery, rum1cro | ||||||||
| Priority: | --- | Flags: | yasu:
maintainer-feedback?
(bdrewery) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
It should really be an optional dependency since not everyone uses 'options'. A lot just use make.conf overrides. I don't mind making it default for package building though. Created attachment 190076 [details] updated patch file (In reply to Bryan Drewery from comment #1) OK, I updated patch so dependency on dialog4ports is optional. And while I am here installation of bundled rm command is removed because no supported FreeBSD version requires it any more. (In reply to Yasuhiro KIMURA from comment #2) > Created attachment 190076 [details] > updated patch file > > (In reply to Bryan Drewery from comment #1) > > OK, I updated patch so dependency on dialog4ports is optional. > > And while I am here installation of bundled rm command is removed because no > supported FreeBSD version requires it any more. Did you read the comment? Please don't remove it. You'll need to rebase your patch now since I won't commit your 'rm' removal and I need to update poudriere-devel. -devel updated. Will update main once I do a release. Created attachment 192916 [details]
updated patch file
Update patch to make it fit to latest ports treee.
So plase commit attached patch instead of previous ones.
Committed, thanks! A commit references this bug: Author: bdrewery Date: Thu May 3 23:10:12 UTC 2018 New revision: 468995 URL: https://svnweb.freebsd.org/changeset/ports/468995 Log: - Add DIALOG4PORTS option (default on) to install it for 'options' command [1]. - Add CERTS option (default on) to allow disabling cert dependencies. - Reword QEMU_DESC to match poudriere-devel. - Only install ZSH files if the option is enabled. PR: 225457 [1] Submitted by: Yasuhiro KIMURA <yasu@utahime.org> [1] (based on) Changes: head/ports-mgmt/poudriere/Makefile A commit references this bug: Author: bdrewery Date: Fri Jun 1 18:33:39 UTC 2018 New revision: 471281 URL: https://svnweb.freebsd.org/changeset/ports/471281 Log: MFH: r468995 r471280 - Add DIALOG4PORTS option (default on) to install it for 'options' command [1]. - Add CERTS option (default on) to allow disabling cert dependencies. - Reword QEMU_DESC to match poudriere-devel. - Only install ZSH files if the option is enabled. PR: 225457 [1] Submitted by: Yasuhiro KIMURA <yasu@utahime.org> [1] (based on) - Update to 3.2.7 Very minor maintenance release. Changes: https://github.com/freebsd/poudriere/wiki/release_notes_327 Approved by: portmgr (implicit) Changes: _U branches/2018Q2/ branches/2018Q2/ports-mgmt/poudriere/Makefile branches/2018Q2/ports-mgmt/poudriere/distinfo |
Created attachment 190066 [details] patch file * Add ports-mgmt/dialog4ports to RUN_DEPENDS because 'options' command uses it to edit options setting. * Bump PORTREVISON because of dependency change.