Bug 225482

Summary:

lang/phantomjs: Fix build with clang 6.0.0

Product:

Ports & Packages

Reporter:

Fukang Chen <loader>

Component:

Individual Port(s)

Assignee:

Mark Felder <feld>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

dim, loader

Priority:

---

Flags:

feld: maintainer-feedback+

Version:

Latest

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

224669

Attachments:

Description	Flags
patch	none

Description Fukang Chen freebsd_committer

2018-01-27 04:38:11 UTC

Created attachment 190096 [details]
patch

https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20180122/634364.html

Add space to avoid literal suffix error.
poudriere log: https://people.freebsd.org/~loader/poudriere/aarch64/phantomjs-2.1.1_7.log.xz

Comment 1 Mark Felder freebsd_committer

2018-02-11 16:38:35 UTC

Approving this as long as I can get confirmation from someone involved in the exp-run as well.

Comment 2 Dimitry Andric freebsd_committer

2018-02-11 17:02:15 UTC

The fix looks fairly standard for this, seems OK to me.  An alternative solution would be to set USE_CXXSTD=gnu++98, but since you only have to change one line, that is probably overkill.

Comment 3 commit-hook freebsd_committer

2018-06-19 03:41:22 UTC

A commit references this bug:

Author: loader
Date: Tue Jun 19 03:40:39 UTC 2018
New revision: 472754
URL: https://svnweb.freebsd.org/changeset/ports/472754

Log:
  lang/phantomjs: Allow building on armv6 and armv7 platforms

  - Patches for armv6 and armv7 are obtained from www/webkit-gtk3
  - Allow building with non-default LOCALBASE
  - Fix build with Clang 6.0.0 [0]

  PR:		225482 [0]
  Reviewed by:	koobs, feld
  Approved by:	koobs (mentor), feld (maintainner)
  Differential Revision:	https://reviews.freebsd.org/D15850

Changes:
  head/lang/phantomjs/Makefile
  head/lang/phantomjs/files/patch-src_qt_qtbase_mkspecs_freebsd-clang_qmake.conf
  head/lang/phantomjs/files/patch-src_qt_qtwebkit_Source_JavaScriptCore_assembler_ARMAssembler.h
  head/lang/phantomjs/files/patch-src_qt_qtwebkit_Source_WTF_wtf_Platform.h
  head/lang/phantomjs/files/patch-src_qt_qtwebkit_Source_WebCore_platform_graphics_cpu_arm_filters_FELightingNEON.cpp
  head/lang/phantomjs/files/patch-src_webpage.cpp