Summary: | devel/boost-python-libs: libboost_numpy* is missing from pkg-plist | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||||||
Component: | Individual Port(s) | Assignee: | FreeBSD Office Team <office> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Some People | CC: | office | ||||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(office) |
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Description
John Hein
2018-01-31 15:18:56 UTC
Created attachment 190286 [details]
[patch] address numpy dependency with explicit option
Here is a patch to solve this problem...
- fix plist for devel/boost-python{,3}-libs if math/py-numpy is installed
by added NUMPY option. If off, disable building libboost_numpy [1].
If on, depend on the numpy port [2]. Default: off - matches current packages.
- minor portlint appeasement
PORTREVISION bump is probably not necessary since it will not change the package contents built by default.
[1] There is probably a better way to force disabling the numpy build (arg to bjam?).
[2] Not sure if this should also be a runtime dependency, but ldd does not indicate a dependency.
Created attachment 190695 [details]
[patch] address numpy dependency with explicit option [v2]
refresh patch after r461885 (flavorize)
maintainer timeout? This is still a problem. Can someone please commit this? Created attachment 192770 [details]
[[patch] address numpy dependency with explicit option [v3]
Refresh patch based on current state of boost and boost-python-lib ports.
- fix plist for devel/boost-python{,3}-libs if math/py-numpy is installed
by added NUMPY option. If off, disable building libboost_numpy [1].
If on, depend on the numpy port [2]. Default: off - matches current packages.
- minor portlint appeasement
Option (if non-default) isn't a good approach as it'd prevent ports depending on libboost_numpy. As USE_PYTHON=flavors is incompatible with custom-defined FLAVORS libboost_numpy probably needs to move into a slave port or maybe wait for subpackaging support i.e., one port produces multiple packages. A commit references this bug: Author: jbeich Date: Sat Jun 8 03:13:23 UTC 2019 New revision: 503700 URL: https://svnweb.freebsd.org/changeset/ports/503700 Log: devel/boost-python-libs: add NumPy support numpy component is always built but runtime dependency is left out until subpackaging to avoid always pulling py-numpy. Consumers should add RUN_DEPENDS+=${PYNUMPY} instead to avoid the following: ImportError: No module named numpy.core._multiarray_umath ImportError: numpy.core._multiarray_umath failed to import PR: 225589 238130 Changes: head/devel/boost-python-libs/Makefile head/devel/boost-python-libs/pkg-plist |