Bug 225674

Summary: Improve description of OPENJPEG option
Product: Ports & Packages Reporter: VK <vlad-fbsd>
Component: Ports FrameworkAssignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Open ---    
Severity: Affects Some People CC: adamw, koobs, kwm, ports-bugs, sunpoet
Priority: --- Keywords: needs-qa, patch
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
Improve description of OPENJPEG option none

Description VK freebsd_triage 2018-02-04 22:56:26 UTC
Created attachment 190328 [details]
Improve description of OPENJPEG option

The OPENJPEG option is used for JPEG 2000 support via OpenJPEG. The alternative support is via JASPER. Most ports use either one or the other. Some may support both.

This patch changes the default description of OPENJPEG option to match, which also better explains what OPENJPEG is really for.
Comment 1 Adam Weinberger freebsd_committer 2018-02-04 23:02:17 UTC
Reassigned to freebsd-ports-bugs. Any committer is welcome to commit to bsd.options.desc.mk.
Comment 2 VK freebsd_triage 2018-02-06 01:33:54 UTC
CC maintainer of graphics/openjpeg for opinion.

A question has been raised on IRC whether OpenJPEG is only about JPEG2000 as I suggest it is, or has a broader scope and thus should NOT be renamed as suggested here.
Comment 3 Po-Chuan Hsieh freebsd_committer 2018-02-12 16:05:38 UTC
Could you provide the irc log? The new description is OK to me.
Comment 4 VK freebsd_triage 2018-02-12 16:36:28 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #3)

Unfortunately I don't have the logs. But I'm CC'ing koobs@, who raised the objection. Namely, I asked him for opinion on clearing up the OPTIONS database wrt usage of OpenJPEG and Jasper, for JPEG2000 support, as I wanted to submit such a patch, and this one here is just a first step.

Two ports, py-pillow and ImageMagick (6, 7) use JPEG2000 named option but really they link against libopenjpeg for those options. All other ports use either OPENJPEG option, or JASPER. So right now there are three OPTIONs for JPEG2000 support, two of which are used for OpenJPEG: OPENJPEG and JPEG2000 for those two ports, which I wanted to consolidate as OPENJPEG. And really, ports either use OpenJPEG, or Jasper, some may have support for both.

Also CC-ing maintainer of ImageMagick.