Bug 225683
| Summary: | sysutils/sbase: Move PREFIX to avoid conflicts | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | tobik | ||||||
| Priority: | --- | Flags: | pkubaj:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
How was this tested? It fails to build. You might have to remove
_XOPEN_SOURCE=700 from config.mk since it hides flock().
Also since you're using a custom prefix please set
MANDIRS=${PREFIX}/${PORTNAME}/man so that the man pages get gzipped properly
by the framework.
--- flock.o ---
flock.c:21:38: error: use of undeclared identifier 'LOCK_EX'
int fd, status, savederrno, flags = LOCK_EX, nonblk = 0, oflag = 0;
^
flock.c:26:12: error: use of undeclared identifier 'LOCK_NB'
nonblk = LOCK_NB;
^
flock.c:32:11: error: use of undeclared identifier 'LOCK_SH'
flags = LOCK_SH;
^
flock.c:35:11: error: use of undeclared identifier 'LOCK_UN'
flags = LOCK_UN;
^
flock.c:38:11: error: use of undeclared identifier 'LOCK_EX'
flags = LOCK_EX;
^
flock.c:50:6: warning: implicit declaration of function 'flock' is invalid in C99 [-Wimplicit-function-declaration]
if (flock(fd, flags | nonblk)) {
^
1 warning and 6 errors generated.
Created attachment 191467 [details]
patch
Sorry, I did remove -D_XOPEN_SOURCE=700 (it's removed in the port), but then I added it by accident in this patch.
Corrected patch is attached. MANPREFIX="${PREFIX}/${PORTNAME}/man" is already set in the previous patch in port's Makefile.
A commit references this bug: Author: tobik Date: Tue Mar 13 14:43:51 UTC 2018 New revision: 464386 URL: https://svnweb.freebsd.org/changeset/ports/464386 Log: sysutils/sbase: Move to separate PREFIX This avoids conflicts with base utilities and coreutils PR: 225683 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> Changes: head/sysutils/sbase/Makefile head/sysutils/sbase/files/patch-config.mk head/sysutils/sbase/pkg-plist Committed. Thanks!
> MANPREFIX="${PREFIX}/${PORTNAME}/man" is already set in the previous patch in port's Makefile.
MANPREFIX != MANDIRS
|
Created attachment 190339 [details] patch After inclusion of sbase in ports I noticed that its binaries conflict with binutils and coreutils. This patch moves sbase to its own PREFIX, which users can include in their PATH. I'm also removing adding ? to "PREFIX =" in config.mk, since ports' PREFIX overrides it.