| Summary: | [icmp] members of icmpstat are still u_long, why not uint64_t? | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Kun Xie <kxie> | ||||
| Component: | kern | Assignee: | freebsd-net (Nobody) <net> | ||||
| Status: | New --- | ||||||
| Severity: | Affects Only Me | Keywords: | patch | ||||
| Priority: | --- | ||||||
| Version: | CURRENT | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 190441 [details] replace u_long to uint64_t in icmpstat r253081 changed all fields of many stat structures to uint64_t to adapt with the PCPU counters, but icmpstat's all fields are still u_long. And then r253084 migrate many structs including icmpstat to PCPU. There is no error while building it because the number of the fields is even, so it might be forgotten, but if a new u_long field is added into the struct, then there will be an build error. A patch to change all fields to uint64_t is attached.