Bug 225820

Summary:

[PATCH] devel/sbt update to 1.1.1

Product:

Ports & Packages

Reporter:

j-keck <jhyphenkeck>

Component:

Individual Port(s)

Assignee:

Alex Dupre <ale>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

jhyphenkeck

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

bugzilla: maintainer-feedback? (ale)

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
patch to update sbt from 1.1.0 to 1.1.1	none
poudriere log	none

Description j-keck 2018-02-11 12:34:13 UTC

Created attachment 190504 [details]
patch to update sbt from 1.1.0 to 1.1.1

patch to update sbt from 1.1.0 to 1.1.1

release notes: https://github.com/sbt/sbt/releases/tag/v1.1.1

----

Notes:

  * this version includes a fix for FreeBSD (sbt fails if a directory is missing):
    https://github.com/sbt/sbt/issues/3894


  * on FreeBSD, sbt use 'java.nio.file.WatchService' [0] to trigger rebuilds if the src changes. 
    By default, this 'WatchService' checks only every 10 seconds [1] for changes and then triggers
    the rebuild - which is a very long time.
    I include a default 'sbtopts' file under 'files/sbtopts' which will be installed to
    '/usr/local/share/sbt/conf/sbtopts' to configure sbt to use it's internal 'PollingWatchService' [2]
    so src changes are detected after 500 millis [3].

[0]: https://github.com/sbt/sbt/blob/d1071002beabc3ec4d5a19453f3cf7f49ea2612f/main-command/src/main/scala/sbt/Watched.scala#L151
[1]: https://github.com/dmlloyd/openjdk/blob/342a565a2da8abd69c4ab85e285bb5f03b48b2c9/src/jdk.unsupported/share/classes/com/sun/nio/file/SensitivityWatchEventModifier.java#L46
[2]: https://github.com/sbt/sbt/blob/d1071002beabc3ec4d5a19453f3cf7f49ea2612f/main-command/src/main/scala/sbt/Watched.scala#L143
[3]: https://github.com/sbt/sbt/blob/d1071002beabc3ec4d5a19453f3cf7f49ea2612f/main-command/src/main/scala/sbt/Watched.scala#L94

Comment 1 j-keck 2018-02-11 12:35:18 UTC

Created attachment 190505 [details]
poudriere log

Comment 2 commit-hook freebsd_committer

2018-02-12 08:38:47 UTC

A commit references this bug:

Author: ale
Date: Mon Feb 12 08:38:44 UTC 2018
New revision: 461563
URL: https://svnweb.freebsd.org/changeset/ports/461563

Log:
  Update to 1.1.1 release.

  Switch back to sbt PollingWatchService to improve filesystem change detection time.

  PR:		225820
  Submitted by:	j-keck <jhyphenkeck@gmail.com>

Changes:
  head/devel/sbt/Makefile
  head/devel/sbt/distinfo
  head/devel/sbt/files/sbt.sh.in