Bug 225867
| Summary: | [PATCH][ADOPT] games/xroach: fix reason for being BROKEN and new maintainer | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Philipp Engel <kidon> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Romain Tartière <romain> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | romain | ||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 190584 [details]
Patch to update the Makefile and distinfo.
Created attachment 190586 [details]
New distinfo.
Hi Philipp, Can you please update this PR to provide a single patch conforming to the recommendations of the FreeBSD Porter's Handbook? https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#svn-diff Thanks! Created attachment 190594 [details]
svn patch
Hi Romain, hope that I've got it right.
Created attachment 190595 [details]
new version
Mercy me, I've forgotten the source code patch.
Excellent! I'll give a look tomorrow A commit references this bug: Author: romain Date: Wed Feb 14 08:08:49 UTC 2018 New revision: 461766 URL: https://svnweb.freebsd.org/changeset/ports/461766 Log: Resurrect, unbreak and modernize games/xroach Submitter is also taking maintainership. PR: 225867 Submitted by: kidon@posteo.de Changes: head/games/xroach/ head/games/xroach/Makefile head/games/xroach/distinfo head/games/xroach/files/patch-Makefile head/games/xroach/files/patch-xroach.c Thank you for resurrecting these cockroaches and taking maintainership! A few notes for your future submissions: - ports-mgmt/portlint can report a variety of problems, it's a good idea to ensure it does not report errors; - You can set DEVELOPER=yes in /etc/make.conf so that more sanity checks are performed when you update ports. I fixed the problems reported by these tools. If you do not understand a change I made, feel free to ask me what happened ;-) |
Created attachment 190583 [details] Patch to update the source code.