Summary: | panic: solaris assert: newds == os->os_dsl_dataset during "zpool upgrade" | ||
---|---|---|---|
Product: | Base System | Reporter: | Alan Somers <asomers> |
Component: | kern | Assignee: | Andriy Gapon <avg> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | avg |
Priority: | --- | ||
Version: | CURRENT | ||
Hardware: | Any | ||
OS: | Any |
Description
Alan Somers
2018-02-13 22:39:47 UTC
A commit references this bug: Author: asomers Date: Tue Feb 13 22:42:25 UTC 2018 New revision: 329248 URL: https://svnweb.freebsd.org/changeset/base/329248 Log: Skip zpool_upgrade_007_pos This test frequently panics. Skip it until the panic is fixed PR: 225877 Sponsored by: Spectra Logic Corp Changes: projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpool_upgrade_test.sh Reassign back to the pool. I'm no longer working on ZFS. A commit references this bug: Author: avg Date: Thu Mar 15 08:49:22 UTC 2018 New revision: 330974 URL: https://svnweb.freebsd.org/changeset/base/330974 Log: MFV r330973: 9164 assert: newds == os->os_dsl_dataset illumos/illumos-gate@5f5913bb83405db87f982abee80162a479d363af https://github.com/illumos/illumos-gate/commit/5f5913bb83405db87f982abee80162a479d363af https://www.illumos.org/issues/9164 This issue has been reported by Alan Somers as https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225877 dmu_objset_refresh_ownership() first disowns a dataset (and releases it) and then owns it again. There is an assert that the new dataset object is the same as the old dataset object. When running ZFS Test Suite on FreeBSD we see this panic from zpool_upgrade_007_pos test: panic: solaris assert: newds == os->os_dsl_dataset (0xfffff80045f4c000 == 0xfffff80021ab4800) I see that the old dataset has dsl_dataset_evict_async() pending in ds_dbu.dbu_tqent and its ds_dbuf is NULL. Reviewed by: Matt Ahrens <mahrens@delphix.com> Reviewed by: Don Brady <don.brady@delphix.com> Approved by: Richard Lowe <richlowe@richlowe.net> Author: Andriy Gapon <avg@FreeBSD.org> PR: 225877 Reported by: asomers MFC after: 1 week Changes: _U head/sys/cddl/contrib/opensolaris/ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_objset.c head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_objset.h head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c A commit references this bug: Author: avg Date: Thu Mar 15 08:52:49 UTC 2018 New revision: 330975 URL: https://svnweb.freebsd.org/changeset/base/330975 Log: re-enable zpool_upgrade_007_pos test after the fix in r330974 The test was disabled in r329248. PR: 225877 Changes: head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpool_upgrade_test.sh A commit references this bug: Author: avg Date: Tue Mar 27 11:33:21 UTC 2018 New revision: 331611 URL: https://svnweb.freebsd.org/changeset/base/331611 Log: MFC r330974: MFV r330973: 9164 assert: newds == os->os_dsl_dataset PR: 225877 Changes: _U stable/11/ stable/11/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_objset.c stable/11/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_objset.h stable/11/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c A commit references this bug: Author: avg Date: Tue Mar 27 11:34:34 UTC 2018 New revision: 331612 URL: https://svnweb.freebsd.org/changeset/base/331612 Log: MFC r330974: MFV r330973: 9164 assert: newds == os->os_dsl_dataset PR: 225877 Changes: _U stable/10/ stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_objset.c stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_objset.h stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c |