Bug 225975
| Summary: | [New Port] mail/rubygem-premailer-rails19 port required for gitlab 10.4 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthias Fechner <mfechner> | ||||
| Component: | Individual Port(s) | Assignee: | Jochen Neumeister <joneum> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Many People | CC: | joneum | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | mfechner:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 225970 | ||||||
| Attachments: |
|
||||||
It's already done by tz@. He already done lots of work for gitlab 10.4.x. BTW, the patch is incorrect. + SUBDIR += rubygem-premailer17 And it should be added (using "svn cp") from mail/rubygem-premailer. (In reply to Sunpoet Po-Chuan Hsieh from comment #1) sry, I cannot do the svn cp stuff. I just started to create PRs for all the work I did the last weeks to get gitlab 10.4 commited as it fixes a critical security update. (In reply to Matthias Fechner from comment #2) no problem Matthias, i will to this for you bevor i commit all update ;-) (In reply to Matthias Fechner from comment #2) You could: - do 'svn cp' in your own repo - submit the diff - note "svn cp revision XXX" in the PR Sometimes committer will forget to do so. It would help to avoid adding ports in a wrong way. Hey Matthias, could you please have a look at the PR again? The headline says "rubygem-premailer-rails19", in mail/makefile "rubygem-premailer17" Would you like rubygem-premailer19? The patch is correct, it is for mail/rubygem-premailer-rails19. But there is a line in www/Makefile for rubygem-premailer19 missing, that is the reason why it is included into the patch. Should I not add lines in the Makefile if a new port is created? Then this PR is not necessary. @tz has already added this port on 15.02.2018: https://www.freshports.org/mail/rubygem-premailer-rails19 If it's okay for you, I'll close here hm, I do not understand it. If I do a svn up it says I'm on revision 462220. But I cannot see this port (this repository is stored in my home dir): cat mail/rubygem-premailer-rails19 cat: mail/rubygem-premailer-rails19: No such file or directory Is this a bug with svn? Sorry, but I stopped using svn a long time ago and it behaves for strange. What can I do to make sure I'm really on revision 462220. Command like git fsck is not existing for svn. Could you please help me here? If I do a portsnap fetch; portsnap update for /usr/ports I see this new port. I use to testing ports an svn tree ~/dev/ports https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/subversion-primer.html you can check this tree anonymous out with: svn co https://svn.FreeBSD.org/ports/head ~/dev/ports and than for all other checkouts "cd ~/dev/ports && svn up" After killing everything and did a fresh checkout it is here, sorry for this PR, seems to be a svn bug. |
Created attachment 190720 [details] port required for gitlab 10.4