Bug 226101

Summary: Patch for audio/rtaudio
Product: Ports & Packages Reporter: Shane <FreeBSD>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed Not Accepted    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (yuri)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239770
Attachments:
Description Flags
additional patch for audio/rtaudio none

Description Shane 2018-02-21 23:55:33 UTC
Created attachment 190877 [details]
additional patch for audio/rtaudio

While starting a new port (audio/vcvrack), I found some changes to rtaudio were needed.

As the maintainer of devel/godot (which has the rtaudio files bundled) I needed to adjust the OSS support to get it to work. To get godot OSS audio working I changed rtaudio to open /dev/dsp instead of /dev/mixer. This change has been part of the godot port for almost 1.5 years without any bug reports.

With vcvrack I needed to make the same changes to audio/rtaudio and also found another issue. The available formats is only listing input formats, this means that the output channels did not have any supported formats and vcvrack would only allow connections to channels with supported formats. This leads to only being able to connect to an input channel when it is trying to output sound.

To get this working I changed the format tests to consider both input and output formats, so the format list becomes a combination of both input and output formats. This leads to every audio port being listed and got sound output working.
Comment 1 Yuri Victorovich freebsd_committer 2018-02-22 03:29:18 UTC
Hi Shane,

Thank you for your inquiry.

I think you should create a pull request for them here: https://github.com/thestk/rtaudio

Port can't be patched so extensively. Port can only include an upstream patch if there is an emergency. "thestk" account there is very responsive in my experience. Once they accept your pull request, I can move the port revision to that point if necessary.

Yuri
Comment 2 Yuri Victorovich freebsd_committer 2018-02-22 09:35:46 UTC
Needs to be submitted upstream.