Bug 226144

Summary:

lagg(4): Upping a lagg interrface should automatically up its children

Product:

Base System

Reporter:

Alan Somers <asomers>

Component:

kern

Assignee:

freebsd-net (Nobody) <net>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

eugen, glebius, ken, vvd

Priority:

---

Keywords:

patch

Version:

CURRENT

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Allow setting MTU on children and automatically up/down children	none

Description Alan Somers freebsd_committer

2018-02-23 17:46:17 UTC

More of a feature request than a bug.  But it would be nice for upping/downing a lagg interface to automatically up/down its children.

Comment 1 Alan Somers freebsd_committer

2018-02-23 17:51:40 UTC

Created attachment 190920 [details]
Allow setting MTU on children and automatically up/down children

Here's a patch that adds the feature, but it still needs a little work to build on head.

Comment 2 Eugene Grosbein freebsd_committer

2018-02-27 17:04:28 UTC

lagg_if_updown() function can "restart" its main loop. How it is guaranteed that it won't do it endlessly?

Comment 3 commit-hook freebsd_committer

2024-05-06 22:28:52 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=570685971c6ad30c75103453a38fdb2dff432bef

commit 570685971c6ad30c75103453a38fdb2dff432bef
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2024-05-06 22:25:53 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-05-06 22:27:32 +0000

    lagg: propagate up/down to the children

    Based on the old submission from asomers@.  With modern state of locking
    in lagg(4), the patch got much simplier.  Enable the test that was
    waiting for this change.

    PR:                     226144
    Reviewed by:            asomers
    Differential Revision:  https://reviews.freebsd.org/D44605

 sys/net/if_lagg.c             | 24 ++++++++++++++++++++++++
 tests/sys/net/if_lagg_test.sh |  1 -
 2 files changed, 24 insertions(+), 1 deletion(-)

Comment 4 Vladimir Druzenko freebsd_committer

2024-05-07 08:05:16 UTC

Gleb, what about MTU?

Comment 5 Alan Somers freebsd_committer

2024-05-07 12:54:44 UTC

Thanks for finishing this, Gleb!