Bug 226232
| Summary: | net/dbeacon: [maintainer] update to 0.3.9.2: adds C++11 support to permit building on 11 && CURRENT | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Chris Hutchinson <portmaster> | ||||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | yuri | ||||||||
| Priority: | --- | Keywords: | easy, patch, patch-ready | ||||||||
| Version: | Latest | Flags: | portmaster:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 191045 [details]
QA log for net/dbeacon
Tests good on CURRENT
It failed on 12i386:
c++ -O2 -pipe -fstack-protector -fno-strict-aliasing -g -Wall -O2 -c -o ssmping.o ssmping.cpp
dbeacon.cpp:419:78: error: invalid operands to binary expression ('__bind<int &, sockaddr *, int>' and 'int')
if (bind(mcastSock, beaconUnicastAddr.saddr(), beaconUnicastAddr.addrlen()) != 0) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
/usr/include/c++/v1/system_error:606:1: note: candidate function not viable: no known conversion from '__bind<int &, sockaddr *, int>' to 'const std::__1::error_code' for 1st argument
operator!=(const error_code& __x, const error_code& __y) _NOEXCEPT
^
(In reply to Yuri Victorovich from comment #2) Ping Chris Hutchinson -) Hi Chris, it should be possible to fix the problem Yuri uncovered by adding USE_CXXSTD=c++98 to the Makefile or by fixing it like we did in ports r471840. (In reply to Tobias Kortkamp from comment #4) > Hi Chris, > > it should be possible to fix the problem Yuri uncovered by adding > USE_CXXSTD=c++98 to the Makefile or by fixing it like we did in ports > r471840. Right you are *again* Tobias! :-) I've been buried lately. As I've just setup a CPAN mirror, and am in the process of creating a replacement for the soon-to-be unplugged search.cpan.org Anyway. I'll post a patch that'll include that shortly. Then I'll go back to it when I'm done with my current events, and fix it *properly*. Thanks! --Chris Created attachment 194298 [details]
svn diff for net/dbeacon (version 2)
New patch, that includes all previous changes as well as;
and this is big; USE_CXXSTD= c++98
;-)
That'll do it. I think we're *finally* done here! :-)
Thanks for all your time, and consideration!
--Chris
Assignee timeout. I'll take care of it. A commit references this bug: Author: tobik Date: Sat Jul 7 10:39:58 UTC 2018 New revision: 474070 URL: https://svnweb.freebsd.org/changeset/ports/474070 Log: net/dbeacon: Fix build with Clang 6 dbeacon.cpp:415:78: error: invalid operands to binary expression ('__bind<int &, sockaddr *, int>' and 'int') ...(bind(mcastSock, beaconUnicastAddr.saddr(), beaconUnicastAddr.addrlen()) != 0) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ - Follow MASTER_SITES redirect PR: 226232 Submitted by: maintainer Changes: head/net/dbeacon/Makefile |
Created attachment 191044 [details] svn diff for net/dbeacon net/dbeacon doesn't build on 11 or CURRENT due to insufficient support for C++11. This update brings this support to net/dbeacon so as to build and operate correctly on 11 && CURRENT. CHANGES bump PORTVERSION convert LICENSE to MIT add USES tar:xz remove files/patch-dbeacon.cpp ... please see the attached svn diff for greater detail. Tests good on CURRENT (see attached QA log for greater detail) That's it! Thanks! --Chris