Bug 226463
| Summary: | devel/py-llvmlite: Add enum34 to RUN_DEPENDS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | David Kalliecharan <dave> | ||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dave, koobs, python, w.schwarzenfeld | ||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(dave) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Upstream lists it as an install_requires (RUN_DEPENDS) only. What is the observed issue if enum34 is not available at build time? If it is indeed required at build time, please ask for them to add it to setup.py:setup_requires as well Forgot to source upstream: https://github.com/numba/llvmlite/blob/master/setup.py#L161 The build complains that enum34 is not available:
File "setup.py", line 74, in run
from llvmlite.utils import get_library_files
File "llvmlite/__init__.py", line 6, in <module>
raise ImportError("could not find the 'enum' module; please install "
ImportError: could not find the 'enum' module; please install it using e.g. 'p
ip install enum34'
*** Error code 1
I will contact the maintainers on github about the issue.
Committed. Thanks! A commit references this bug: Author: sunpoet Date: Sat Mar 10 23:04:45 UTC 2018 New revision: 464130 URL: https://svnweb.freebsd.org/changeset/ports/464130 Log: Add missing RUN_DEPENDS - Bump PORTREVISION for dependency change PR: 226463 Submitted by: David Kalliecharan <dave@dal.ca> (maintainer) Changes: head/devel/py-llvmlite/Makefile For the record, enum34 should be removed from BUILD_DEPENDS. David has reported it to upstream [1]. [1] https://github.com/numba/llvmlite/issues/334 |
Created attachment 191321 [details] py-llvmlite.diff patch Issue found with devel/py-llvmlite requiring both devel/py-enum34 for both {BUILD,RUN}_DEPENDS. This was tested with poudriere 11.1, 10.4 amd64. Reported by Gleb Popov.