Bug 226464
| Summary: | graphics/p5-Image-ExifTool: Update to 10.80 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tod McQuillin <devin> | ||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | devin | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(devin) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Tod McQuillin
2018-03-09 01:16:03 UTC
Thanks David Please set the maintainer-approval attachment flag to + to signify maintainer approval on patches for ports you maintainer. Attachment -> Details -> maintainer-approval [+] Also, can you please confirm this change passes QA (portlint, poudriere) or not? This patch has passed portlint and 'port test' from ports-mgmt/porttools Hi,
Regarding the DOCS installation, I would like to simplify Makefile as follows:
@@ -23,23 +23,11 @@
PORTDOCS= *
-DOCSRCDIR1= ${WRKSRC}
-DOC_FILES1= Changes README
-
-DOCSRCDIR2= ${DOCSRCDIR1}/html
-DOCSDIR2= ${DOCSDIR}/html
-DOC_FILES2= *.css *.html *.pdf
-
-DOCSRCDIR3= ${DOCSRCDIR2}/TagNames
-DOCSDIR3= ${DOCSDIR2}/TagNames
-DOC_FILES3= *.css *.html
-
OPTIONS_DEFINE= DOCS
-post-install:
- @${MKDIR} ${STAGEDIR}${DOCSDIR3}
- ${INSTALL_DATA} ${DOC_FILES1:S|^|${DOCSRCDIR1}/|} ${STAGEDIR}${DOCSDIR}
- ${INSTALL_DATA} ${DOC_FILES2:S|^|${DOCSRCDIR2}/|} ${STAGEDIR}${DOCSDIR2}
- ${INSTALL_DATA} ${DOC_FILES3:S|^|${DOCSRCDIR3}/|} ${STAGEDIR}${DOCSDIR3}
+post-install-DOCS-on:
+ @${MKDIR} ${STAGEDIR}${DOCSDIR}
+ ${INSTALL_DATA} ${WRKSRC}/Changes ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}
+ cd ${WRKSRC}/ && ${COPYTREE_SHARE} html ${STAGEDIR}${DOCSDIR}
.include <bsd.port.mk>
It also fix a problem that ${WRKSRC}/html/overview.png is not installed.
% cd `make -V WRKSRC`
% ls html/overview.png
html/overview.png
% grep overview.png html/*
html/under.html:<center><img src="overview.png" alt="ExifTool Overview" width="680" height="460"></center>
A commit references this bug: Author: sunpoet Date: Sat Mar 10 23:01:38 UTC 2018 New revision: 464115 URL: https://svnweb.freebsd.org/changeset/ports/464115 Log: Update to 10.80 - While I'm here: - Simplify DOCS installation - Convert to options target helper Changes: http://search.cpan.org/dist/Image-ExifTool/Changes PR: 226464 Submitted by: Tod McQuillin <devin@spamcop.net> (maintainer) Changes: head/graphics/p5-Image-ExifTool/Makefile head/graphics/p5-Image-ExifTool/distinfo head/graphics/p5-Image-ExifTool/pkg-plist Committed. Thanks! |
