Summary: | [PATCH] www/chromium: add CUPS option | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Craig Leres <leres> | ||||||||
Component: | Individual Port(s) | Assignee: | freebsd-chromium (Nobody) <chromium> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | cpm | ||||||||
Priority: | --- | Flags: | cpm:
maintainer-feedback+
|
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Description
Craig Leres
2018-03-10 20:38:35 UTC
Created attachment 191378 [details]
patch
Here is the patch set. With maintainer approval I'm happy to take this bug and create a differential to commit it.
Created attachment 191379 [details]
poudriere testport build log with CUPS disabled
I removed most of the build lines because even compressed it was too large to attach.
CUPS_DESC is defined in Mk/bsd.options.desc.mk, please remove this line: +CUPS_DESC= Disable cups support (note: this completely disables printing) Created attachment 191419 [details]
patch
Revised patch without CUPS_DESC.
(In reply to Craig Leres from comment #4) LGTM. Feel free to commit the patch :) A commit references this bug: Author: leres Date: Mon Mar 12 17:44:37 UTC 2018 New revision: 464264 URL: https://svnweb.freebsd.org/changeset/ports/464264 Log: Add a CUPS option to disable cups support and remove the dependency on print/cups. This includes a patch from cpm@ that solves an undefined linker reference that occurs when cups is disabled. Since chromium does not support printing without cups enabling this option also disables printing and print previews. PR: 226505 Reviewed by: cpm, matthew (mentor) Approved by: cpm, matthew (mentor) Differential Revision: https://reviews.freebsd.org/D14659 Changes: head/www/chromium/Makefile head/www/chromium/files/patch-chrome_service_cloud__print_print__system.cc (In reply to commit-hook from comment #6) Good job, Craig :) |