Bug 226608
| Summary: | mail/crm114 - gettext and iconv dependencies are surplus | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Igor Sysoev <igor> | ||||||
| Component: | Individual Port(s) | Assignee: | Matthias Andree <mandree> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | igor, mandree | ||||||
| Priority: | --- | Flags: | chalpin:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Igor Sysoev
2018-03-14 16:22:28 UTC
Corey, any opinion? Created attachment 207298 [details]
Proposed patch.
As far as I can tell, the iconv dependency is indeed superfluous at this point. (From the svn logs at https://svnweb.freebsd.org/ports/head/mail/crm114/Makefile?revision=101979&view=markup that dependency has been present since the port was created. I'm not sure if it was needed at some point or if it's always been superfluous). However, the crm114 binary links libintl and so the port needs at least gettext-runtime, but probably not gettext itself. The attached patch removes the iconv dependency and replaces gettext with gettext-runtime. It passes poudriere testport and works in the testing I've done. However, it's been some years since I used crm114. So the testing I did consisted of installing it and filtering a single message. For that reason, the attached patch also drops my maintainership. A commit references this bug: Author: mandree Date: Sun Sep 8 20:38:50 UTC 2019 New revision: 511596 URL: https://svnweb.freebsd.org/changeset/ports/511596 Log: Reduce number of requisites. Corey has decided to give up maintainership. Thanks for your past efforts! While here, run ${STRIP_CMD} on executables in bin/. PR: 226608 Submitted by: Corey Halpin (maintainer) Reported by: Igor Sysoev Changes: head/mail/crm114/Makefile I've also added a ${STRIP_CMD} to the post-install to conform to ports framework conventions.
Created attachment 207484 [details]
Removed gettext-runtime dependence.
Thank you for your work.
It seems however that crm114 does not use gettext-runtime at all.
There are no dependencies on the library inside crm114 and it is
linked and works successfully without libintl:
/usr/local/bin/crm:
libtre.so.5 => /usr/local/lib/libtre.so.5 (0x800894000)
libm.so.5 => /lib/libm.so.5 (0x800aa7000)
libc.so.7 => /lib/libc.so.7 (0x800cd7000)
The attached patch removes gettext-runtime dependencies.
(In reply to Igor Sysoev from comment #6) please see comment #3 and argue if this is true for all ports-supported FreeBSD versions. (In reply to Matthias Andree from comment #7) I can only state that the latest version of crm114-20100106-BlameMichelson.src.tar.gz does not contain any occurences of "libintl", "gettext", "textdomain" used in gettext API. A commit references this bug: Author: mandree Date: Mon Oct 21 18:39:30 UTC 2019 New revision: 515119 URL: https://svnweb.freebsd.org/changeset/ports/515119 Log: mail/crm114: strip gettext-runtime requisite PR: 226608 Reported by: Igor Sysoev Changes: head/mail/crm114/Makefile |
