Bug 226723
| Summary: | net-mgmt/victorops-nagios: Add icinga2 configuration files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Luca Pizzamiglio <pizzamig> | ||||
| Component: | Individual Port(s) | Assignee: | Luca Pizzamiglio <pizzamig> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | doug.rand | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(doug.rand) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Luca Pizzamiglio
2018-03-19 11:03:08 UTC
Reporter is committer, assign accordingly @Luca It looks like a patch is missing Since the reporter is a ports committer, I'm not sure that that my approval is required. But on the odd chance that something or someone is waiting on it: Approved. Created attachment 192362 [details]
The patch
This patch add victorops icinga2 configuration files as weel
As committer, I can directly commit the PR, but I don't want to overstep the maintainer. So the approval is needed. Moreover, I completely forgot the patch, so now the maintainer can review it and set the flag to approve (if everything is fine). I've tested the build on several FreeBSD version and everything looks fine. Comment on attachment 192362 [details]
The patch
Looks good and straightforward to me.
Thanks for the patch, and the work!
A commit references this bug: Author: pizzamig Date: Thu Apr 12 21:03:17 UTC 2018 New revision: 467197 URL: https://svnweb.freebsd.org/changeset/ports/467197 Log: net-mgmt/victorops-nagios: Add icinga2 configuration files PR: 226723 Approved by: rand@iteris.com (maintainer) Sponsored by: trivago N.V. Changes: head/net-mgmt/victorops-nagios/Makefile head/net-mgmt/victorops-nagios/pkg-plist |