Bug 226829

Summary: [NEW PORT] mail/astroid: Graphical mail client
Product: Ports & Packages Reporter: Mylan Connolly <mylan>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: w.schwarzenfeld, yuri
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://astroidmail.github.io/
Attachments:
Description Flags
Diff for the port
none
Updated diff, including fix for gmime none

Description Mylan Connolly 2018-03-21 17:24:33 UTC 
Created attachment 191712 [details]
Diff for the port

I wrote a port for astroid, (homepage: http://astroidmail.github.io/).

This is my first attempt at porting, so I'd appreciate any feedback that can be provided. I attempted to follow the handbook as closely as I can.

Program seems to compile fine and I believe I caught all of the dependencies / ran through all of the testing steps shown in the handbook.

Thanks!
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-21 21:41:32 UTC 
The build fails for me:

===>  Building for astroid-0.11.1
[1/4] cd /usr/ports/mail/astroid/work/astroid-0.11.1 && /usr/local/bin/g-ir-scanner --warn-all --namespace=Astroid --nsversion=0.1 --add-include-path=/usr/ports/mail/astroid/work/astroid-0.11.1 --output /usr/ports/mail/astroid/work/astroid-0.11.1/Astroid-0.1.gir --no-libtool --program=/usr/ports/mail/astroid/work/astroid-0.11.1/gir_main --include=GObject-2.0 --include=GMime-2.6 /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/astroid_activatable.c /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_view_activatable.c /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_index_activatable.c /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/astroid_activatable.h /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_view_activatable.h /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_index_activatable.h /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/gir_main.c
FAILED: Astroid-0.1.gir 
cd /usr/ports/mail/astroid/work/astroid-0.11.1 && /usr/local/bin/g-ir-scanner --warn-all --namespace=Astroid --nsversion=0.1 --add-include-path=/usr/ports/mail/astroid/work/astroid-0.11.1 --output /usr/ports/mail/astroid/work/astroid-0.11.1/Astroid-0.1.gir --no-libtool --program=/usr/ports/mail/astroid/work/astroid-0.11.1/gir_main --include=GObject-2.0 --include=GMime-2.6 /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/astroid_activatable.c /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_view_activatable.c /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_index_activatable.c /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/astroid_activatable.h /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_view_activatable.h /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/thread_index_activatable.h /usr/ports/mail/astroid/work/astroid-0.11.1/src/plugin/gir_main.c
Couldn't find include 'GMime-2.6.gir' (search path: '['/usr/ports/mail/astroid/work/astroid-0.11.1', u'/usr/local/share/gir-1.0', u'/usr/share/gir-1.0', u'/usr/local/share/gir-1.0', u'/usr/share/gir-1.0', u'/usr/local/share/gir-1.0']')
ninja: build stopped: subcommand failed.
Comment 2 Mylan Connolly 2018-03-21 22:10:48 UTC 
Created attachment 191723 [details]
Updated diff, including fix for gmime

Thanks for the feedback, I noticed a typo in the Makefile (referenced the wrong version of gmime; my machine already had the correct version of gmime installed, so I did not notice the problem).

Attached an updated diff that should resolve this issue.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-21 22:24:19 UTC 
No, changing the dependency can't fix it. It still fails.
Comment 4 Mylan Connolly 2018-03-22 13:18:19 UTC 
Hmm, okay I will probably have to look at this more, then. It is still successfully building on my machine. I'll do some more research and see what can be done.

Thanks.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-22 17:36:08 UTC 
(In reply to Mylan Connolly from comment #4)

You should build in poudriere. It fails there too.
You local computer build isn't enough to know it isn't broken.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-23 22:46:13 UTC 
This looks like an upstream bug: https://github.com/astroidmail/astroid/issues/485
Comment 7 Walter Schwarzenfeld freebsd_triage 2018-03-27 02:12:49 UTC 
I don't know if this is right or relevant, but it builds with
CMAKE_ARGS+=    -DDISABLE_PLUGINS:BOOL=true
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-27 02:14:58 UTC 
(In reply to w.schwarzenfeld from comment #7)

Yes, thanks, that's what upstream also suggested. This disables some gtk introspection code that breaks, which is in plugins.
Comment 9 Walter Schwarzenfeld freebsd_triage 2019-08-08 05:43:59 UTC 
ping!
Comment 10 commit-hook freebsd_committer freebsd_triage 2019-08-08 07:59:18 UTC 
A commit references this bug:

Author: yuri
Date: Thu Aug  8 07:59:04 UTC 2019
New revision: 508365
URL: https://svnweb.freebsd.org/changeset/ports/508365

Log:
  New port: mail/astroid: Graphical email client for notmuch, inspired by sup and others

  PR:		226829
  Submitted by:	Mylan Connolly <mylan.connolly@gmail.com>

Changes:
  head/mail/Makefile
  head/mail/astroid/
  head/mail/astroid/Makefile
  head/mail/astroid/distinfo
  head/mail/astroid/files/
  head/mail/astroid/files/patch-CMakeLists.txt
  head/mail/astroid/pkg-descr
  head/mail/astroid/pkg-plist
Comment 11 Yuri Victorovich freebsd_committer freebsd_triage 2019-08-08 07:59:22 UTC 
Committed.
Thank you for your contribution!