Bug 226927

Summary: [PATCH] security/trousers: libressl 2.7 build failure
Product: Ports & Packages Reporter: Charlie Li <vishwin>
Component: Individual Port(s)Assignee: Bernard Spil <brnrd>
Status: Closed FIXED    
Severity: Affects Some People CC: brnrd
Priority: --- Flags: bugzilla: maintainer-feedback? (hrs)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://sourceforge.net/p/trousers/bugs/222/
See Also: https://reviews.freebsd.org/D14849
Bug Depends on:    
Bug Blocks: 226843    

Description Charlie Li freebsd_committer freebsd_triage 2018-03-25 21:02:57 UTC
security/libressl-devel features the new LibreSSL 2.7, which introduced compatibility with most of OpenSSL 1.1 and 1.0.2 APIs. Consequently, the patch as it stands in this port fails to detect such and treats all LibreSSL as OpenSSL < 1.1.

This updated patch fixes the build. Throwing it up in Phabricator shortly.
Comment 1 Charlie Li freebsd_committer freebsd_triage 2018-03-25 21:07:33 UTC
Forgot to mention, testport succeeds with all supported values of ssl= in DEFAULT_VERSIONS.
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2018-04-02 18:05:57 UTC
Add link to upstream bug report https://sourceforge.net/p/trousers/bugs/222/
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2018-04-21 21:12:18 UTC
A commit references this bug:

Author: brnrd
Date: Sat Apr 21 20:38:38 UTC 2018
New revision: 467906
URL: https://svnweb.freebsd.org/changeset/ports/467906

Log:
  security/trousers: Fix build with LibreSSl 2.7

   - LibreSSL 2.7 adds OpenSSL 1.1 API

  PR:           227169
  Approved by:  maintainer time-out

Changes:
  head/security/trousers/files/patch-src_trspi_crypto_openssl_rsa.c