Bug 226981

Summary: multimedia/libxine: fails to link with ld.bfd 2.28
Product: Ports & Packages Reporter: Ed Maste <emaste>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed Unable to Reproduce    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214864

Description Ed Maste freebsd_committer freebsd_triage 2018-03-27 14:18:27 UTC 
As part of testing WIP to migrate to lld as the system linker I have removed the in-tree ld.bfd 2.17.50 from my working tree. I have lld installed as /usr/bin/ld, and have ld.bfd 2.28 from ports (my usr/bin/ld.bfd is a symlink to the one from ports).

Libxine has LLD_UNSAFE=yes already and so will use ld.bfd for linking, but it appears our libxine depends on misbehaviour only available in the outdated ld.bfd 2.17.50. With 2.28 the build fails with:

/usr/bin/ld.bfd: .libs/xine.o: relocation R_X86_64_PC32 against protected symbol `_x_flags' can not be used when making a shared object
/usr/bin/ld.bfd: final link failed: Bad value
cc: error: linker command failed with exit code 1 (use -v to see invocation)
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-03-27 14:41:09 UTC 
A commit references this bug:

Author: emaste
Date: Tue Mar 27 14:40:47 UTC 2018
New revision: 465707
URL: https://svnweb.freebsd.org/changeset/ports/465707

Log:
  multimedia/quark: set LLD_UNSAFE

  Ports using libxine fail to link due to shared library protected
  visibility symbol preemption issues.  Set LLD_UNSAFE to use ld.bfd.

  PR:		214864, 226981
  Approved by:	portmgr (LLD_UNSAFE blanket)
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/multimedia/quark/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-03-27 14:44:17 UTC 
A commit references this bug:

Author: emaste
Date: Tue Mar 27 14:44:07 UTC 2018
New revision: 465708
URL: https://svnweb.freebsd.org/changeset/ports/465708

Log:
  multimedia/gxine: set LLD_UNSAFE

  Ports using libxine fail to link due to shared library protected
  visibility symbol preemption issues.  Set LLD_UNSAFE to use ld.bfd.

  PR:		214864, 226981
  Approved by:	portmgr (LLD_UNSAFE blanket)
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/multimedia/gxine/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-03-27 15:01:37 UTC 
A commit references this bug:

Author: emaste
Date: Tue Mar 27 15:01:12 UTC 2018
New revision: 465711
URL: https://svnweb.freebsd.org/changeset/ports/465711

Log:
  multimedia/k9copy-kde4: set LLD_UNSAFE

  Ports using libxine fail to link due to shared library protected
  visibility symbol preemption issues.  Set LLD_UNSAFE to use ld.bfd.

  PR:		214864, 226981
  Approved by:	portmgr (LLD_UNSAFE blanket)
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/multimedia/k9copy-kde4/Makefile
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-12-28 05:37:25 UTC 
(In reply to Ed Maste from comment #0)
I cannot reproduce this now.  Can this be closed?  Or is there something left
to do?