Bug 227127

Summary: www/squid-devel: update to 4.0.24, add BDB option
Product: Ports & Packages Reporter: ncrogers
Component: Individual Port(s)Assignee: Luca Pizzamiglio <pizzamig>
Status: Closed FIXED    
Severity: Affects Some People CC: ncrogers, pizzamig, timp87
Priority: --- Flags: timp87: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
update to 4.0.24, add BDB option
none
update to 4.0.24, add BDB option (disabled by default) none

Description ncrogers 2018-03-30 22:25:10 UTC 
Created attachment 191994 [details]
update to 4.0.24, add BDB option

This patch updates squid-devel to the latest version 4.0.24.

http://squid-web-proxy-cache.1019090.n4.nabble.com/squid-announce-Squid-4-0-24-beta-is-available-td4685043.html

I've also included an option to exclude Berkeley DB support, as my organization has concerns over its license. bdb was recently added to USES in this commit:
https://svnweb.freebsd.org/ports?view=revision&revision=438126

The "BDB" option seems to follow the general ports convention of how bdb support is included or not. Only the ext_session_acl and ext_time_quota_acl require Berkeley DB support, so it seems safe to optionally exclude it. To be consistent with the new behavior of this port I've enabled BDB by default. Perhaps there is a more appropriate way to configure this?

I've also tried including support for the ext_session acl helper, which also relies on BDB.

Thanks for your consideration.
Comment 1 ncrogers 2018-03-30 22:32:56 UTC 
poudriere testport output

https://gist.github.com/courtland/3bd5e6f38f678c57688ab6a2b3f8feb5
Comment 2 Pavel Timofeev 2018-04-01 19:16:03 UTC 
Comment on attachment 191994 [details]
update to 4.0.24, add BDB option

Great! Thanks a lot!
I would have no objectiona if BDB was turned off by default.
Comment 3 ncrogers 2018-04-02 19:30:31 UTC 
BDB off by default seems reasonable to me since neither of the squid ports (3.x and 4.x) have required that before. I will update the diff.
Comment 4 ncrogers 2018-04-02 19:31:15 UTC 
Created attachment 192116 [details]
update to 4.0.24, add BDB option (disabled by default)
Comment 5 Pavel Timofeev 2018-04-02 19:35:46 UTC 
I wanted to mark the latest patch with '+', but bugzilla ignores my attempts
Comment 6 ncrogers 2018-04-02 20:47:17 UTC 
I marked the first one as obsolete.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-04-13 09:22:28 UTC 
A commit references this bug:

Author: pizzamig
Date: Fri Apr 13 09:21:52 UTC 2018
New revision: 467220
URL: https://svnweb.freebsd.org/changeset/ports/467220

Log:
  www/squid-devel: update to 4.0.24, add BDB option

  PR:		227127
  Submitted by:	ncrogers@gmail.com
  Approved by:	timp87@gmail.com (maintainer)

Changes:
  head/www/squid-devel/Makefile
  head/www/squid-devel/distinfo
  head/www/squid-devel/files/patch-src_ipc_Kid.cc
  head/www/squid-devel/pkg-plist
Comment 8 Luca Pizzamiglio freebsd_committer freebsd_triage 2018-04-13 09:34:25 UTC 
Committed, thanks!