Bug 227147

Summary: Clean up keywords: needs-staging, patch, patch-ready, s/panic/crash, et al
Product: Services Reporter: Mateusz Piotrowski <0mp>
Component: Bug TrackerAssignee: Kubilay Kocak <koobs>
Status: In Progress ---    
Severity: Affects Only Me CC: bugmeister, gonzo, linimon
Priority: --- Keywords: needs-qa
Version: unspecified   
Hardware: Any   
OS: Any   

Description Mateusz Piotrowski freebsd_committer 2018-03-31 22:12:30 UTC
The link[1] in the description of "needs-staging" in the Bugzilla keywords list[3] to is broken as it was recently renamed[2].

[1]: https://wiki.freebsd.org/ports/StageDir
[2]: https://wiki.freebsd.org/Ports/StageDir
[3]: https://bugs.freebsd.org/bugzilla/describekeywords.cgi
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-04-01 00:07:28 UTC
(In reply to Mateusz Piotrowski from comment #0)

I've worked around it on the wiki side by using a page redirect.  (I learned something new today.)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-04-01 02:23:58 UTC
The needs-staging keyword is deprecated, mostly cause all ports are already staged, and all new ports must be stagedir compliant. 

I had not removed it earlier are there are other keywords which need to change/remove/be added, and sometimes functionality (auto-assigner) can rely on or use/add keywords in certain cases, and may not resiliently handle their non-presence.

I'll work with @gonzo to verify the latter is not the case, and remove it once that has been identified.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-04-01 02:26:07 UTC
In the meantime, I've fixed the description link, added deprecated messaging to it's description, and will delete the redirected page (after seeing if any other pages in the wiki depend on it)
Comment 4 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2018-04-09 07:34:00 UTC
(In reply to Kubilay Kocak from comment #2)

Needs staging is not used in auto-assigner, so it's safe to remove it.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-04-09 10:20:00 UTC
(In reply to Oleksandr Tymoshenko from comment #4)


the auto assignment of keyword:patch based on [tags] in summary has now been removed iirc?

Beyond that, are there additions/removals of any keywords in the AA code left at this stage?
Comment 6 Mateusz Piotrowski freebsd_committer 2021-01-16 22:06:35 UTC
Is there anything else we can do here?
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-01-17 03:41:20 UTC
Yep, need to test and confirm  (needs-qa) whether global keyword removal cascades metadata removal from objects with that keyword.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2021-01-17 03:42:43 UTC
*hitting upstream again to get confirmation from bugzilla 5.x codebase*
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2021-01-17 04:34:35 UTC

justdave | Yes, it does.  https://github.com/bugzilla/bugzilla/blob/5.2/Bugzilla/DB/Schema.pm#L600