Bug 227150

Summary: [NEW PORT] sysutils/rw: Block device and byte copying program similar to dd
Product: Ports & Packages Reporter: Jesse Smith <jsmith>
Component: Individual Port(s)Assignee: Kirill Ponomarev <krion>
Status: Closed FIXED    
Severity: Affects Only Me CC: 0mp, krion
Priority: --- Keywords: feature, needs-qa
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
rw port shell archive
Updated port with new commit and website
Updated version of port none

Description Jesse Smith 2018-04-01 01:49:53 UTC
Created attachment 192022 [details]
rw port shell archive

rw is a byte copying tool which copies blocks of raw bytes from one file or stream to another. It was written for Sortix with an effort to replace dd with standard style command line arguments.

The shar for the rw port is attached.
Comment 1 Jesse Smith 2018-04-02 15:33:07 UTC
Created attachment 192108 [details]
Updated port with new commit and website

This is a new version of the port with an updated website and a new upstream source commit that contains bug fixes.
Comment 2 Mateusz Piotrowski freebsd_committer 2018-04-16 08:21:17 UTC
(In reply to jsmith from comment #1)

Hello! Thank you for your submission!

I've got a couple of suggestions:

1. It might be a better idea to use https://gitlab.com/sortix/rw-portable instead of https://gitlab.com/sortix/sortix.
2. Try to run `portlint -AC` on your Makefile to fix some style issues.
3. The directory for manual pages is /usr/local/man on FreeBSD (not /usr/local/share/man).


BTW, you've been spotted ;) https://sortix.org/rw/
Comment 3 Jesse Smith 2018-04-17 19:52:11 UTC
Created attachment 192597 [details]
Updated version of port
Comment 4 Jesse Smith 2018-04-17 19:52:58 UTC
I have updated the port to use rw-portable 1.0 and the port now pulls from the official download location.
Comment 5 Mateusz Piotrowski freebsd_committer 2018-04-17 20:33:14 UTC
(In reply to jsmith from comment #4)

Cool! Thanks for updating the patch. There are, however, still a couple of issues:

 * The license is invalid. See Chapter 5.7 of the Porter's Handbook[1] for a list of valid license symbols.
 * There's probably no need to define do-install and do-build. The distribution of rw has a Makefile, which does everything for us. Hint: you might want to define post-install in order to use ${STRIP_CMD}.[2] 
 * There are a lot of style problems. You my list them using portlint and then fix warnings until portlint says "looks fine.". You may install portlint with `pkg install ports-mgmt/portlint`.

[1]: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses.html
[2]: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/install.html
Comment 6 commit-hook freebsd_committer 2018-04-18 12:03:03 UTC
A commit references this bug:

Author: krion
Date: Wed Apr 18 12:02:32 UTC 2018
New revision: 467706
URL: https://svnweb.freebsd.org/changeset/ports/467706

  rw is a command line program which copies information between files
  or byte streams. The rw command is designed to be a replacement for
  dd with standard style command line flags.

  WWW: https://sortix.org/rw/

  PR:		227150
  Submitted by:	jsmith@resonatingmedia.com