Bug 227202

Summary: databases/sqlitebrowser: Use system QScintilla
Product: Ports & Packages Reporter: Adriaan de Groot <adridg>
Component: Individual Port(s)Assignee: Adriaan de Groot <adridg>
Status: Closed FIXED    
Severity: Affects Only Me CC: lbartoletti
Priority: --- Keywords: needs-qa
Version: LatestFlags: lbartoletti: maintainer-feedback+
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D14930
See Also: https://github.com/sqlitebrowser/sqlitebrowser/issues/1361

Description Adriaan de Groot freebsd_committer freebsd_triage 2018-04-02 13:14:24 UTC
The port uses a now-redundant USE_QT5 flag (version 3.10 of the port supports *only* Qt5). Remove that.

Use system QScintilla instead of the embedded copy of Scintilla. Fix up finding the system QScintilla. Although we *could* stick to the bundled version, that would require some hacky patches to get that to build in the face of changed include orders generated by CMake. See upstream issue https://github.com/sqlitebrowser/sqlitebrowser/issues/1361 and FBSD review https://reviews.freebsd.org/D14930
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2018-04-13 16:07:16 UTC
Closed in https://reviews.freebsd.org/D14930