Bug 227209
| Summary: | [patch] sysutils/geomWatch stable/11-llvm6 (r331838) fallout [-W reserved-user-defined-literal] | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Harald Schmalzbauer <bugzilla.freebsd> |
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | dim, dmgk, dvl, spawk |
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(spawk) |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Created attachment 192115 [details]
zfs-sysevent.h: Insert whitespaces for C++11 compile werror.
Sorry, file-attachment seems to have interfered with the wrong one I pasted...
Ahh, "details" and "diff" differ... Only the "details" show to patch-patch, "diff" decapsules the inner patch. -harry Created attachment 192170 [details]
Make geomWatch obey USE_CXXSTD=gnu++98 option
Here is an alternate patch, which:
* Makes geomWatch obey the USE_CXXSTD setting, by adding ${CXXFLAGS} to the compilation command line.
* Sets USE_CXXSTD to gnu++98, so no messing with the ZFS code needs to be done.
*** Bug 230261 has been marked as a duplicate of this bug. *** A commit references this bug: Author: dvl Date: Wed Aug 8 14:58:33 UTC 2018 New revision: 476645 URL: https://svnweb.freebsd.org/changeset/ports/476645 Log: Fix broken building PR: 227209 Submitted by: Harald Schmalzbauer <bugzilla.freebsd@omnilan.de> Dmitri Goutnik <dg@syrec.org> Approved by: maintainer (timeout 4 months)) Changes: head/sysutils/geomWatch/Makefile head/sysutils/geomWatch/files/patch-Makefile Thank you both. |
Created attachment 192113 [details] zfs-sysevent.h: Insert whitespaces for C++11 compile werror. After r331838, geomwatch fails to compile with: In file included from geomWatch.cpp:41: In file included from ./zpool.hpp:35: In file included from zfs/v28/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h:38: In file included from zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_ioctl.h:30: In file included from zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio.h:29: In file included from zfs/v28/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h:83: zfs/v28/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h:79:37: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-W reserved-user-defined-literal] #define SUNW_KERN_PUB SUNW_VENDOR":"SE_KERN_PUB Attached is q q'n'd patch to sysutils/geomWatch (the port). -harry