Bug 227229
| Summary: | databases/mysql56-server: Adapt ${name}_limits to the new resource limiting mechanics for services | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mateusz Piotrowski <0mp> |
| Component: | Individual Port(s) | Assignee: | Mahdi Mokhtari <mmokhi> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | Keywords: | regression |
| Priority: | --- | Flags: | mmokhi:
maintainer-feedback+
mmokhi: maintainer-feedback+ |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227435 | ||
| Bug Depends on: | |||
| Bug Blocks: | 227205 | ||
| Attachments: | |||
|
Description
Mateusz Piotrowski
2018-04-03 00:50:07 UTC
Created attachment 192145 [details]
Patch adding support for the new ${name}_limits mechanics (databases/mysql56-server, revision: 2)
I forgot to remove the previous fix entirely in the previous patch. Here's a new one.
Hi, Thanks for nice work, reduced for me A LOT :D I'll test it and feedback to you by afternoon (my local time ``:D). Hi again. Tested the patch, my 12 poudriere jail was 1200056 and it failed, so I changed the Makefile condition to include it and it came fixed. Everything else was fine so far, are you ok if I commit it with my change or I'm missing something about 1200056 vs 1200057 thing? (In reply to Mahdi Mokhtari from comment #3) Ah. So two things: * 1200056 and 1200057 is not exactly precise. The change was introduced in between those two versions: 1200056 is r327952, 1200057 is r329033 and the change was introduced in r328331. I guess it is not really solvable easily. I'd argue that the best idea is to update CURRENT machines to at least 1200057. * The bigger problem is with the "${OSVERSION} < 1101515" as I made an off-by-one error. It should be 1101514 which will be the next value of __FreeBSD_version: 1101513 is r331838, the change was backported in r331880 and it will be included it the next version (1101514). Thank you for spotting it. I'll submit fixed patches today. Created attachment 192226 [details]
Patch adding support for the new ${name}_limits mechanics (databases/mysql56-server, revision: 3)
The previous patch would fail to trigger the new ${name}_limits semantics for __FreeBSD_version 1101514. The new patch fixes it (thanks to mmokhi@).
A commit references this bug: Author: mmokhi Date: Wed Apr 4 20:45:15 UTC 2018 New revision: 466505 URL: https://svnweb.freebsd.org/changeset/ports/466505 Log: databases/mysql56-server: Adapt ${name}_limits to the new mechanism Regarding to the changes to rc.subr(8) it is no longer necessary to define a resource limiting logic in service scripts. limits(1) is now run by default and its configuration is handled via the "${name}_limits" variable. This however causes collision of variable names and also is not compatible with the old mechanism. This fixes the rc-script of mysql56 for the bases with both old and new mechanism. PR: 227229 Submitted by: 0mp Reported by: 0mp Sponsored by: Netzkommune GmbH Changes: head/databases/mysql56-server/Makefile head/databases/mysql56-server/files/mysql-server.in head/databases/mysql56-server/pkg-plist Committed, thanks a lot for your help :) (In reply to Mahdi Mokhtari from comment #7) Great! Thank you for actually devoting some time to test out this patch and catching that little bug. :) (In reply to Mateusz Piotrowski from comment #8) Oh sure thing __/||\__ Thanks again for revising it 3 times :) |