Bug 227261

Summary: mail/postgrey: conflict of PG_USER variable with PostgreSQL
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Only Me CC: pi, ports.maintainer
Priority: --- Flags: ports.maintainer: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
make.conf variables change per suggestion
ports.maintainer: maintainer-approval+
poudriere testport log
none
patch to update variables in the rc script ports.maintainer: maintainer-approval+

Description Piotr Kubaj freebsd_committer 2018-04-03 16:20:45 UTC
Postgrey uses the same variables for changing default user as PostgreSQL. Could that be changed, to e.g. POSTGREY_USER?

For now, if you change the default in make.conf and compile both ports, you may be surprised that PostgreSQL doesn't use postgres user by default.
Comment 1 Rin Morningstar 2018-04-03 20:01:01 UTC
Created attachment 192182 [details]
make.conf variables change per suggestion
Comment 2 Rin Morningstar 2018-04-03 20:01:29 UTC
Created attachment 192183 [details]
poudriere testport log
Comment 3 Rin Morningstar 2018-04-04 08:34:40 UTC
Thanks for catching this! Fixed.

Committer: the patch includes an addition to UPDATING since there is potential end-user steps needed with this change.
Comment 4 Kurt Jaeger freebsd_committer 2018-04-16 17:18:08 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer 2018-04-16 17:18:35 UTC
A commit references this bug:

Author: pi
Date: Mon Apr 16 17:18:01 UTC 2018
New revision: 467493
URL: https://svnweb.freebsd.org/changeset/ports/467493

Log:
  mail/postgrey: fix conflict of PG_USER variable with PostgreSQL

  Please note:

  20180416:
    AFFECTS: users of mail/postgrey
    AUTHOR: ports.maintainer@evilphi.com

    If you use any of the optional make.conf variables to specify the
    postgrey user, group, db dir, or run dir when building the port, you will
    need to change the prefix from PG_ to POSTGREY_*.  The variables were
    renamed to solve a namespace collision with the PostgreSQL ports.

  PR:		227261
  Submitted by:	Melissa Pilgrim <ports.maintainer@evilphi.com> (maintainer)
  Reported by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/UPDATING
  head/mail/postgrey/Makefile
  head/mail/postgrey/pkg-plist
Comment 6 Rin Morningstar 2018-04-16 23:08:27 UTC
Created attachment 192574 [details]
patch to update variables in the rc script

The original patch omitted necessary changes in files/postgrey.in, so catch that file up as well.
Comment 7 commit-hook freebsd_committer 2018-04-17 04:40:10 UTC
A commit references this bug:

Author: pi
Date: Tue Apr 17 04:40:07 UTC 2018
New revision: 467559
URL: https://svnweb.freebsd.org/changeset/ports/467559

Log:
  mail/postgrey: fix files/postgrey.in for PG_* -> POSTGREY_* variables

  PR:		227261
  Submitted by:	Melissa Pilgrim <ports.maintainer@evilphi.com> (maintainer)
  Reported by:	Pierre Guinoiseau <pierre@guinoiseau.eu>, Paul Blazejowski <paulb@blazebox.homeip.net>

Changes:
  head/mail/postgrey/Makefile
  head/mail/postgrey/files/postgrey.in