Bug 227298
| Summary: | deskutils/note: update to v. 1.3.22 (patch). | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alexandre C. Guimarães <rigoletto> | ||||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||||
| Severity: | Affects Only Me | CC: | mfechner | ||||||||||||||||||||
| Priority: | --- | Flags: | mfechner:
maintainer-feedback+
|
||||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
I do not use this port anymore so I cannot test it. Would you like to take over as maintainer? Created attachment 192254 [details]
Updating to v1.3.22.
Also taking maintainership.
Created attachment 192255 [details]
Update to v1.3.22.
I've forgot to add the patch to svn.
Anyway. It seem to still need some work, I bring later.
Created attachment 192258 [details]
Update to v1.3.22
Add missing dependencies and create OPTIONS: CRYPTO, MYSQL, and PWSAFE3.
Remove the patch and use sed instead.
Thanks!
Created attachment 192270 [details]
Update to v1.3.22.
One more missing dependency found.
Created attachment 192272 [details]
Update to v1.3.22.
Final one I guess.
Thanks.
Created attachment 192273 [details]
Update to v1.3.22.
Add examples.
Created attachment 192274 [details]
Update to v1.3.22
Let's add more options for encryption.
Sorry about that many changes but the documentation is not that good. It took some time to get everything because there were a need to actually test specific things to find the missing stuff.
Thanks!
(In reply to Alexandre C. Guimarães from comment #8) should I wait a little bit more or do you think it is ready now? (In reply to Matthias Fechner from comment #9) I think it is fine now. I could not find anything missing anymore. ^^ Thanks! :) I found a problem. 'security/p5-Crypt-CBC' and 'security/p5-Crypt-Rijndael' are just needed when at least one of the OPTIONS_GROUP_CRYPTO is ON. I tried setting CRYPTO_RUN_DEPENDS in a hope of covering the entire group, but didn't work. So, the only two possible solutions coming to mind are: 1 - set those dependencies in the general RUN_DEPENDS or 2 - repeat them to each OPTION of the group. Basically bloated vs. ugly, unless there is proper solution I am not aware of. Thanks! Created attachment 192313 [details]
Updating to 1.3.22.
Done.
My time is currently limited as I do work on upgrade for the gitlab port, so I just approve this change, but I have not tested it. I created now a revision to get it committed: https://reviews.freebsd.org/D15066 The moment it got approved, I will commit it. A commit references this bug: Author: krion Date: Sun Apr 15 11:10:29 UTC 2018 New revision: 467383 URL: https://svnweb.freebsd.org/changeset/ports/467383 Log: Update to version 1.3.22 Pass maintainership to submitter as agreed with previous maintainer PR: 227298 Submitted by: Alexandre C. Guimar?es <lebarondemerde@privacychain.ch> Approved by: idefix@fechner.net Changes: head/deskutils/note/Makefile head/deskutils/note/distinfo head/deskutils/note/pkg-descr head/deskutils/note/pkg-plist |
Created attachment 192246 [details] Update to version 1.3.22. Hi. Attached a patch to: - update to v1.3.22 - fix run time (minor) Thanks!