Bug 227304

Summary: [PATCH] devel/cgit: build proper manpage for cgitrc(5)
Product: Ports & Packages Reporter: Marko Turk <mt-bugs>
Component: Individual Port(s)Assignee: Adam Weinberger <adamw>
Status: Closed FIXED    
Severity: Affects Many People Flags: bugzilla: maintainer-feedback? (adamw)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
none
patch to build manpage with asciidoc none

Description Marko Turk 2018-04-05 19:49:55 UTC
Created attachment 192257 [details]
patch

Hi,

cgit has cgitrc.5.txt documentation written in asciidoc format for manpages. a2x tool can be used to convert this to manpage.

BR,
Marko
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2018-04-12 12:08:29 UTC
Hi Marko,

Thanks for submitting this PR. Building and installing the manpage sounds like a great idea.

I dislike forced dependencies on things with multiple dependencies when they're avoidable. Can you rework this with the manpage build/install behind an ASCIIDOC option that defaults to on?

Also, do you have any interest in maintaining this port? I've stopped using it.
Comment 2 Marko Turk 2018-04-15 14:05:11 UTC
Created attachment 192527 [details]
patch to build manpage with asciidoc
Comment 3 Marko Turk 2018-04-15 14:06:17 UTC
Hi,

I added new patch with ASCIIDOC option added.

I'm currently using the port so you can add me as a maintainter.

/Marko
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-04-15 17:05:16 UTC
A commit references this bug:

Author: adamw
Date: Sun Apr 15 17:04:30 UTC 2018
New revision: 467401
URL: https://svnweb.freebsd.org/changeset/ports/467401

Log:
  Add an option (defaulting to on) to build and install the cgitrc(5)
  manpage.

  Submitter becomes maintainer.

  PR:		227304
  Submitted by:	Marko Turk

Changes:
  head/devel/cgit/Makefile
  head/devel/cgit/pkg-plist
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2018-04-15 17:06:13 UTC
Great work on that patch, Marko. I've committed the patch along with the maintainer change. Thanks for your work!