Bug 227327

Summary: archivers/unrar: quote CXX and STRIP_CMD to make ccache/cross compile friendly
Product: Ports & Packages Reporter: guyyur
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (sunpoet)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
quote CXX and STRIP_CMD in MAKE_ARGS none

Description guyyur 2018-04-06 17:23:07 UTC
Created attachment 192292 [details]
quote CXX and STRIP_CMD in MAKE_ARGS

Attaching patch to quote CXX and STRIP_CMD in MAKE_ARGS that modifies archivers/unrar/Makefile.

Makes it ccache friendly and cross compile friendly by supporting compiler and strip command with spaces.
(For example: CXX="clang++ --target=...")
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-04-08 18:30:48 UTC
Committed. Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-04-08 18:31:18 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Apr  8 18:30:08 UTC 2018
New revision: 466824
URL: https://svnweb.freebsd.org/changeset/ports/466824

Log:
  Allow compiler and strip command with space.

  It helps for ccache and cross-compiling.

  PR:		227327
  Submitted by:	Guy Yur <guyyur@gmail.com>

Changes:
  head/archivers/unrar/Makefile