Bug 227375

Summary:

net-mgmt/klg: Fix build for PHP>=7

Product:

Ports & Packages

Reporter:

Daniel Austin <freebsd-ports>

Component:

Individual Port(s)

Assignee:

Matthias Fechner <mfechner>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

mfechner, yuri

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

freebsd-ports: maintainer-feedback+

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
fix build on php7+, also dependancies on 5.6	freebsd-ports: maintainer-approval+
also add php flavor support	freebsd-ports: maintainer-approval+
re-patch newer ports tree	freebsd-ports: maintainer-approval+
re-patch newer ports tree	freebsd-ports: maintainer-approval+

Description Daniel Austin 2018-04-08 15:30:46 UTC

Created attachment 192342 [details]
fix build on php7+, also dependancies on 5.6

Fix build on PHP 7+
Also fix dependancies on PHP 5.6 (mysqli not mysql for all PHP versions now)
Update Makefile to remove all portlint warnings

Poudriere testport logs for 10.4/11.1 i386/amd64 located at:

https://poudriere.dan.tm/poudriere/data/latest-per-pkg/klg/1.5_1/

Comment 1 Daniel Austin 2018-04-08 17:52:50 UTC

Created attachment 192346 [details]
also add php flavor support

as per previous patch, but adds flavor support.

Poudriere testport logs at:

https://poudriere.dan.tm/poudriere/data/latest-per-pkg/klg-php56/1.5_1/

Comment 2 Matthias Fechner freebsd_committer

2018-10-20 11:10:14 UTC

Could you please update the patch, it fails to apply.

Comment 3 Daniel Austin 2018-10-20 18:01:06 UTC

Created attachment 198408 [details]
re-patch newer ports tree

re-run patch so that it patches against current ports tree

Comment 4 Daniel Austin 2018-10-20 18:02:10 UTC

Created attachment 198409 [details]
re-patch newer ports tree

re-patch against newer ports tree

Comment 5 Daniel Austin 2018-10-20 18:02:40 UTC

(In reply to Matthias Fechner from comment #2)
this should apply against the latest ports tree now :)

Comment 6 commit-hook freebsd_committer

2018-10-20 18:30:41 UTC

A commit references this bug:

Author: mfechner
Date: Sat Oct 20 18:30:12 UTC 2018
New revision: 482613
URL: https://svnweb.freebsd.org/changeset/ports/482613

Log:
  Fix build on PHP 7+.
  Also fix dependancies on PHP 5.6 (mysqli not mysql for all PHP versions now).
  Update Makefile to remove all portlint warnings.
  Add flavour support.

  PR:		227375
  Submitted by:	freebsd-ports@dan.me.uk
  Reported by:	freebsd-ports@dan.me.uk
  Reviewed by:	mfechner@FreeBSD.org
  Approved by:	mentors (implicit)

Changes:
  head/net-mgmt/klg/Makefile

Comment 7 Matthias Fechner freebsd_committer

2018-10-20 18:31:00 UTC

Thanks!