Bug 227378

Summary:

www/suphp: Add php flavor support, fix portlint and other warnings

Product:

Ports & Packages

Reporter:

Daniel Austin <freebsd-ports>

Component:

Individual Port(s)

Assignee:

Bryan Drewery <bdrewery>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

bdrewery, mfechner

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

bugzilla: maintainer-feedback? (bdrewery)
freebsd-ports: maintainer-feedback? (bdrewery)

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
add flavor support, fix portlint warnings etc.	freebsd-ports: maintainer-approval? (bdrewery)

Description Daniel Austin 2018-04-08 17:37:00 UTC

Created attachment 192345 [details]
add flavor support, fix portlint warnings etc.

Add PHP flavor support.
Add LICENSE
Fix portlint warnings (strip .so file, fix @exec in plist)
Regenerate patches with makepatch

Bryan: I'm happy to take over maintainer of this port if you'd prefer - I use it heavily so have no issue with maintaining it.

Poudriere testport logs for 10.4/11.1 i386/amd64 located at:

https://poudriere.dan.tm/poudriere/data/latest-per-pkg/suphp-php56/0.7.2_2/

Comment 1 Daniel Austin 2018-10-20 10:50:50 UTC

please could someone look at this to commit it?  it's been 6 months now :-(

Comment 2 commit-hook freebsd_committer

2018-10-20 11:33:51 UTC

A commit references this bug:

Author: mfechner
Date: Sat Oct 20 11:33:30 UTC 2018
New revision: 482491
URL: https://svnweb.freebsd.org/changeset/ports/482491

Log:
  Add PHP flavor support.
  Add LICENSE
  Fix portlint warnings (strip .so file, fix @exec in plist)
  Regenerate patches with makepatch
  Change maintainer as requested.

  PR:		227378
  Submitted by:	freebsd-ports@dan.me.uk
  Reported by:	freebsd-ports@dan.me.uk
  Reviewed by:	mfechner@FreeBSD.org
  Approved by:	maintainer timeout

Changes:
  head/www/suphp/Makefile
  head/www/suphp/files/patch-configure.ac
  head/www/suphp/files/patch-doc__suphp.conf-example
  head/www/suphp/files/patch-doc_suphp.conf-example
  head/www/suphp/files/patch-src_SmartPtr.hpp
  head/www/suphp/pkg-plist

Comment 3 Matthias Fechner freebsd_committer

2018-10-20 11:34:32 UTC

Thanks!
I also changed the maintainer to you.

Comment 4 Bryan Drewery freebsd_committer

2018-11-13 23:06:09 UTC

Thank you for picking this up. Sorry I missed it!
If you get sick of the port feel free to pass it back to me as I'm relying on it.
I'd rather it not be deleted.

Comment 5 Daniel Austin 2018-11-14 06:33:29 UTC

(In reply to Bryan Drewery from comment #4)
No problem - I use it heavily on lots of servers (both personally, and in my job), so i'll keep on top of it.
The flavor support makes it so much easier now too.