Bug 227435

Summary: databases/mysql56-server, databases/mysql57-server, databases/mysql80-server: Remove the new ${name}_limits behavior from 11-STABLE
Product: Ports & Packages Reporter: Mateusz Piotrowski <0mp>
Component: Individual Port(s)Assignee: Mahdi Mokhtari <mmokhi>
Status: Closed FIXED    
Severity: Affects Some People CC: chris
Priority: --- Keywords: patch-ready, regression
Version: LatestFlags: mmokhi: maintainer-feedback+
mmokhi: maintainer-feedback+
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227229
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227230
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227231
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225657
Bug Depends on:    
Bug Blocks: 227205    
Attachments:
Description Flags
Patch adding support for the new ${name}_limits mechanics (databases/mysql56-server, revision: 4)
0mp: maintainer-approval?
Patch adding support for the new ${name}_limits mechanics (databases/mysql57-server, revision: 4)
0mp: maintainer-approval?
Patch adding support for the new ${name}_limits mechanics (databases/mysql80-server, revision: 4) 0mp: maintainer-approval?

Description Mateusz Piotrowski freebsd_committer 2018-04-11 00:32:02 UTC
Due to an increasing number of problems caused by the new ${name}_limits behavior, the revision, which was backported from 12-CURRENT to 11-STABLE, has now been reverted.[1] As a result, the new behavior will not be present in any FreeBSD version < 12. 

These new patches adapts listed MySQL server ports to those latest changes.

[1]: https://svnweb.freebsd.org/base?view=revision&revision=r332363
Comment 1 Mateusz Piotrowski freebsd_committer 2018-04-11 00:33:28 UTC
Created attachment 192422 [details]
Patch adding support for the new ${name}_limits mechanics (databases/mysql56-server, revision: 4)
Comment 2 Mateusz Piotrowski freebsd_committer 2018-04-11 00:33:51 UTC
Created attachment 192423 [details]
Patch adding support for the new ${name}_limits mechanics (databases/mysql57-server, revision: 4)
Comment 3 Mateusz Piotrowski freebsd_committer 2018-04-11 00:34:18 UTC
Created attachment 192424 [details]
Patch adding support for the new ${name}_limits mechanics (databases/mysql80-server, revision: 4)
Comment 4 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-04-11 07:55:18 UTC
Ok :)
All patches seems fine :) I'll commit them asap.
Just a point, we should update the UPDATING regarding to the "plan-change" yup?
Comment 5 Mateusz Piotrowski freebsd_committer 2018-04-11 12:58:36 UTC
(In reply to Mahdi Mokhtari from comment #4)

Thanks for reviewing the patches!

I guess so :)

I've prepared an entry for UPDATING here[1]. Ideally, we would have one entry for all the ports affected by the new ${name}_limits behavior but it seems a little bit hard to make maintainers of ~20 ports to cooperate. I don't know we should handle it. 

[1]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227205#c5
Comment 6 commit-hook freebsd_committer 2018-04-11 14:38:12 UTC
A commit references this bug:

Author: mmokhi
Date: Wed Apr 11 14:37:41 UTC 2018
New revision: 467049
URL: https://svnweb.freebsd.org/changeset/ports/467049

Log:
  databases/mysql56-server: Fix ${name}_limits regression on 11-STABLE
  The commit adding the ${name}_limits to 11 is reverted in r332363
  Change the Makefile conditions/vars so that
   new ${name}_limits mechanism is only present on 12-CURRENT (>=1200057)

  PR:		227435
  Reported by:	0mp

Changes:
  head/databases/mysql56-server/Makefile
Comment 7 commit-hook freebsd_committer 2018-04-11 14:41:17 UTC
A commit references this bug:

Author: mmokhi
Date: Wed Apr 11 14:40:52 UTC 2018
New revision: 467051
URL: https://svnweb.freebsd.org/changeset/ports/467051

Log:
  databases/mysql57-server: Fix ${name}_limits regression on 11-STABLE
  This is port of r467049 (that was done on mysql56-server)

  PR:		227435
  Reported by:	0mp

Changes:
  head/databases/mysql57-server/Makefile
Comment 8 commit-hook freebsd_committer 2018-04-11 14:42:20 UTC
A commit references this bug:

Author: mmokhi
Date: Wed Apr 11 14:42:06 UTC 2018
New revision: 467052
URL: https://svnweb.freebsd.org/changeset/ports/467052

Log:
  databases/mysql80-server: Fix ${name}_limits regression on 11-STABLE
  This is port of r467049 (that was done on mysql56-server)

  PR:		227435
  Reported by:	0mp

Changes:
  head/databases/mysql80-server/Makefile
Comment 9 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-04-11 14:46:52 UTC
(In reply to Mateusz Piotrowski from comment #5)
> Thanks for reviewing the patches!
My pleasures :) __/||\__


> I guess so :)

> I've prepared an entry for UPDATING here[1]. Ideally, we would have one entry for all the ports affected by the new ${name}_limits behavior but it seems a little bit hard to make maintainers of ~20 ports to cooperate. I don't know we should handle it. 
> 
> [1]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227205#c5
Yes, I think it's not easy to deal with all >20 ppl :D
My suggestion would be to run an exp-run of the port of this change to all affected ports, then pass the PR#227205 to a portmgr@ guy (they ideally would commit the change if the maintainers didn't respond in 2 weeks :D)

Anyway, I appreciate all your helps during the change ;D thanks for the contribution.