Bug 227463
| Summary: | mail/cyrus-imapd30: Enable cyradm(1) to use p5-Term-Readline-Gnu | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Peter Laursen <freebsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Hajimu UMEMOTO <ume> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | freebsd | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(ume) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 192450 [details] Patch adding dependency --- mail/cyrus-imapd30/Makefile.orig 2018-04-12 12:56:35.753580000 +0200 +++ mail/cyrus-imapd30/Makefile 2018-04-12 13:28:19.700458000 +0200 @@ -2,7 +2,7 @@ PORTNAME= cyrus-imapd PORTVERSION= 3.0.5 -PORTREVISION= 1 +PORTREVISION= 2 #PORTREVISION= 1 CATEGORIES= mail ipv6 MASTER_SITES= ftp://ftp.cyrusimap.org/cyrus-imapd/ \ @@ -46,6 +46,7 @@ CPE_VENDOR= cmu CPE_PRODUCT= cyrus_imap_server +RUN_DEPENDS+= p5-Term-ReadLine-Gnu>=0:devel/p5-Term-ReadLine-Gnu OPTIONS_DEFINE= AUTOCREATE BACKUP CLAMAV HTTP IDLED LDAP LMDB MURDER \ MYSQL NNTP PGSQL REPLICATION SNMP SQLITE SQUAT XAPIAN \ DOCS Created attachment 192452 [details]
Version 2 of the patch
This should be the correct patch - I had forgotten to include a package version in the original submission which made my Poudriere choke.
A commit references this bug: Author: ume Date: Sat Apr 14 04:21:50 UTC 2018 New revision: 467285 URL: https://svnweb.freebsd.org/changeset/ports/467285 Log: Add options to use the command line editing feature by cyradm. PR: 227463 Reported by: Peter Laursen Changes: head/mail/cyrus-imapd30/Makefile Thank you for the report. I've just committed it but modified to make it as an option. This dependency is not necessary to use the readline by cyradm. You can enable the command line editing by just installing p5-Term-Readline-Gnu. So, I don't enable it by default to avoid extra dependency. |
Created attachment 192450 [details] Patch adding dependency Hi, Near the bottom of the cyradm(1) man page it is stated that if the perl module Term::ReadLine::GNU is installed, cyradm(1) will be able to use that module for line editing. (This probably applies to the other mail/cyrus-imapd* ports as well, though I have not tested that). To enable cyradm(1) to use line editing, I have added a dependency on p5-Term-ReadLine-Gnu to RUN_DEPENDS and bumped the PORTREVISION to 2. Both things should be attached in this admittedly small patch. I am slightly unsure where to paste the RUN_DEPENDS line in the Makefile, so feel free to move things around if it conflicts with style etc. All the best, Peter.