Bug 227802
| Summary: | dns/maradns: Update 2.0.15 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | takefu | ||||||
| Component: | Individual Port(s) | Assignee: | Mathieu Arnold <mat> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | ||||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Why rename bind2csv2 to bind2csv2.py ? Also, please, do not rewrite all the Makefile for absolutely no reason, it makes it very hard to see what you are trying to do, and obfuscate everything. For example, this:
- ${INSTALL_MAN} ${WRKSRC}/doc/en/man/*.1 ${STAGEDIR}${MANPREFIX}/man/man1
- ${INSTALL_MAN} ${WRKSRC}/doc/en/man/*.8 ${STAGEDIR}${MANPREFIX}/man/man8
- ${INSTALL_MAN} ${WRKSRC}/doc/en/man/*.5 ${STAGEDIR}${MANPREFIX}/man/man5
+.for i in askmara.1 bind2csv2.1 getzone.1 fetchzone.1 mqhash.1\
+ maradns.8 zoneserver.8 duende.8\
+ mararc.5 csv1.5 csv2.5 csv2_txt.5 Deadwood.1
+ ${INSTALL_MAN} ${WRKSRC}/doc/en/man/${i}\
+ ${STAGEDIR}${MANPREFIX}/man/${i:C|.*\.|man|}/${i:C|\.*||}
+.endfor
Is absolutely ludicrous, the first one was very clear and easy to read, your new version is completely obfuscated.
(In reply to Mathieu Arnold from comment #1) bind2csv2.py is my mistake. Makefile broke the line to accommodate 80 characters per line, but if you do not like it, would you like to change it without changing it? (In reply to Mathieu Arnold from comment #2) Obfuscation. It can not be helped thought so. Just as I reviewed it now, this change is already unnecessary. So I will patch it again. There seemed to be reasons for rewriting to such a patch, but it seems that it got stale. Created attachment 192954 [details]
maradns-2.0.15.patch2
A commit references this bug: Author: mat Date: Thu May 3 14:05:55 UTC 2018 New revision: 468929 URL: https://svnweb.freebsd.org/changeset/ports/468929 Log: Update to 2.0.15. PR: 227802 Submitted by: new maintainer Sponsored by: Absolight Changes: head/dns/maradns/Makefile head/dns/maradns/distinfo head/dns/maradns/files/patch-configure head/dns/maradns/files/patch-tools__Makefile |
Created attachment 192837 [details] maradns-2.0.15.patch Update to 2.0.15 fix Shebangfix warning when CONV option is not used. MAKE_ENV deleted. Delete sourceforge from MASTER_SITES.