Bug 228057

Summary: devel/gogs: Add dependency on bash
Product: Ports & Packages Reporter: Nathan Reilly <nreilly>
Component: Individual Port(s)Assignee: Kirill Ponomarev <krion>
Status: Closed FIXED    
Severity: Affects Many People CC: bsd, dmgk, krion, nreilly
Priority: --- Flags: bugzilla: maintainer-feedback? (dmgk)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Add shells/bash runtime dependendency dmgk: maintainer-approval+

Description Nathan Reilly 2018-05-08 03:48:56 UTC
Hello,

Per https://gogs.io/docs/intro/troubleshooting (at the bottom), gogs requires bash for the hook scripts. It is not currently listed as a dependency for gogs in this port.

Thanks,
Nathan
Comment 1 Dmitri Goutnik freebsd_committer 2018-05-08 22:34:40 UTC
Created attachment 193194 [details]
Add shells/bash runtime dependendency
Comment 2 commit-hook freebsd_committer 2018-05-09 17:46:34 UTC
A commit references this bug:

Author: krion
Date: Wed May  9 17:45:38 UTC 2018
New revision: 469456
URL: https://svnweb.freebsd.org/changeset/ports/469456

Log:
  Add shells/bash dependency as it's required by gogs hooks scripts.

  PR:		228057
  Submitted by:	maintainer

Changes:
  head/devel/gogs/Makefile
Comment 3 Ivan 2018-05-09 20:23:09 UTC
This is wrong. Gogs hooks are autogenerated with SCRIPT_TYPE value for shebang. Any interpreter can be set here. Better to revert this patch.