Bug 228176
| Summary: | textproc/tkdiff: improve the port, and take MAINTAINERship | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Chris Hutchinson <portmaster> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | CC: | fernape | ||||||||||
| Priority: | --- | Keywords: | easy, patch, patch-ready | ||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 193300 [details]
QA LOG for textproc/tkdiff
Proves it builds, and installs as expected,
and that the ports framework has no complaints. :-)
Take Hi Chris, Thanks for the patch. The QA looks good and portlint output is clean. However, the handling of the icons did not pass my mentor's bar :) Any chances of changing the format? Here is the review I created: https://reviews.freebsd.org/D15480 Created attachment 193593 [details] version 2 (superceeds previously submitted patch) Updated version incorporating change suggested by Mat in review D15480 Thanks! --Chris Created attachment 193615 [details]
version 3 (superceeds previously submitted patch)
OK this update simply renames the files in ${FILESDIR}
as requested by @tcberner
Please see review #D15509 for further detail(s).
--Chris
A commit references this bug: Author: fernape Date: Wed May 23 21:59:35 UTC 2018 New revision: 470725 URL: https://svnweb.freebsd.org/changeset/ports/470725 Log: textproc/tkdiff: port improvements * add DESKTOP_ENTRY * add converters/base64 as BUILD_DEPENDS * add icons Also give maintainership to portmaster@bsdforge.com PR: 228176 Submitted by: portmaster@bsdforge.com Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D15480 Changes: head/textproc/tkdiff/Makefile head/textproc/tkdiff/files/ head/textproc/tkdiff/files/icon128.base64 head/textproc/tkdiff/files/icon256.base64 head/textproc/tkdiff/files/icon32.base64 head/textproc/tkdiff/files/icon64.base64 Committed, Thanks Chris for your work, rework and for your patience :) (In reply to Fernando Apesteguía from comment #7) > Committed, > > Thanks Chris for your work, rework and for your patience :) ...and Thank *you*, Fernando! :-) --Chris |
Created attachment 193299 [details] svn diff for textproc/tkdiff I was working on a pr(1), and needed something like this, so I built it, and noticed it could be improved, and had no maintainer. So while already here, I made some changes, and added myself as MAINTAINER. :-) CHANGES o add DESKTOP_ENTRY o add converters/base64 as BUILD_DEPENDS o add icons o take MAINTAINER the addition of the BUILD_DEPENDS was because it seems far more portable distributing icons as base64 packed files in the ports files/ folder. Further; I'm pretty sure that anyone with a mail client already has base64 installed, anyway. :-) See the attached svn diff for greater detail. That's it! Thanks! --Chris