Bug 228181

Summary: devel/tclbsd: pet portlint
Product: Ports & Packages Reporter: Chris Hutchinson <portmaster>
Component: Individual Port(s)Assignee: freebsd-tcltk (Nobody) <tcltk>
Status: Closed FIXED    
Severity: Affects Some People CC: gahr
Priority: --- Keywords: easy, patch, patch-ready
Version: LatestFlags: bugzilla: maintainer-feedback? (tcltk)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
svn diff for devel/tclbsd
none
QA LOG for devel/tclbsd none

Description Chris Hutchinson 2018-05-11 23:40:19 UTC
Created attachment 193305 [details]
svn diff for devel/tclbsd

I installed this, and noticed portlint was whining
about a couple things. So I fixed them. :-)

CHANGES
 o add USE_LDCONFIG as required
 o add ${STRIP_CMD} as required

That's it!

--Chris

Please see attached svn diff (patch), and QA LOG for details.

HTH
Comment 1 Chris Hutchinson 2018-05-11 23:41:41 UTC
Created attachment 193306 [details]
QA LOG for devel/tclbsd

transcript of build output, and the ports framework output.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-05-22 08:07:53 UTC
A commit references this bug:

Author: gahr
Date: Tue May 22 08:07:47 UTC 2018
New revision: 470598
URL: https://svnweb.freebsd.org/changeset/ports/470598

Log:
  devel/tclbsd: strip shared library

  PR:		228181 (based on)
  Submitted by:	Chris Hutchinson <portmaster@bsdforge.com>

Changes:
  head/devel/tclbsd/Makefile
Comment 3 Pietro Cerutti freebsd_committer freebsd_triage 2018-05-22 08:09:41 UTC
Thanks, I have applied the part to strip the shared library, although in your diff it used to refer to LOCALBASE, while it should refer to PREFIX.

I won't apply the LDCONFIG part, as this shared library is not looked up using the usual linker mechanics.