Bug 228252

Summary: sysutils/py-google-compute-engine: fix metadata script bash usage
Product: Ports & Packages Reporter: Helen Koike <helen.koike>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Some People CC: gjb, python, swills
Priority: --- Keywords: easy
Version: LatestFlags: helen.koike: merge-quarterly?
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228411
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228428
Attachments:
Description Flags
Patch to fix py-google-compute-engine to version 2.7.6-2 generated using diff -u -r -N olddir newdir
helen.koike: maintainer-approval+
Poudriere build logs of google-compute-engine package 2.7.6_2 none

Description Helen Koike 2018-05-14 17:09:14 UTC
Created attachment 193399 [details]
Patch to fix py-google-compute-engine to version 2.7.6-2 generated using diff -u -r -N olddir newdir

google_metadata_script_runner tries to execute startup/shutdown scripts with bash, but bash is not a dependency and it crashes unless bash is installed, rendering the GCE startup/shutdown functionality useless when creating a new instance.

Please see attached patch.
Also please merge this in the quarterly ports branch (as this is an important fix for GCE image to work properly).

Thanks
Comment 1 Helen Koike 2018-05-14 17:09:44 UTC
Created attachment 193400 [details]
Poudriere build logs of google-compute-engine package 2.7.6_2
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-05-22 23:52:52 UTC
A commit references this bug:

Author: swills
Date: Tue May 22 23:52:41 UTC 2018
New revision: 470666
URL: https://svnweb.freebsd.org/changeset/ports/470666

Log:
  sysutils/py-google-compute-engine: Fix hostname and bash usage

  PR:		228428
  PR:		228252
  Submitted by:	Helen Koike <helen.koike@collabora.com> (maintainer)

Changes:
  head/sysutils/py-google-compute-engine/Makefile
  head/sysutils/py-google-compute-engine/files/google_set_hostname
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_metadata__scripts_script__executor.py
  head/sysutils/py-google-compute-engine/pkg-plist
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-05-22 23:55:59 UTC
A commit references this bug:

Author: swills
Date: Tue May 22 23:55:00 UTC 2018
New revision: 470667
URL: https://svnweb.freebsd.org/changeset/ports/470667

Log:
  MFH: r470666

  sysutils/py-google-compute-engine: Fix hostname and bash usage

  PR:		228428
  PR:		228252
  Submitted by:	Helen Koike <helen.koike@collabora.com> (maintainer)

  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2018Q2/
  branches/2018Q2/sysutils/py-google-compute-engine/Makefile
  branches/2018Q2/sysutils/py-google-compute-engine/files/google_set_hostname
  branches/2018Q2/sysutils/py-google-compute-engine/files/patch-google__compute__engine_metadata__scripts_script__executor.py
  branches/2018Q2/sysutils/py-google-compute-engine/pkg-plist
Comment 4 Steve Wills freebsd_committer freebsd_triage 2018-05-22 23:57:11 UTC
Committed, thanks!