Bug 228265

Summary: audio/fluidsynth: Update to 1.1.11
Product: Ports & Packages Reporter: takefu
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs, tobik
Priority: --- Keywords: needs-qa, patch
Version: LatestFlags: riggs: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fluidsynth-1.1.11.patch
none
fluidsynth-1.1.11.patch
none
fluidsynth-1.1.11.patch none

Description takefu 2018-05-15 06:21:55 UTC
Created attachment 193413 [details]
fluidsynth-1.1.11.patch

Change
  LICENSE LGPL20+ -> LGPL21
  MASTER_SITES SOURCEFORGE -> GitHub
Comment 1 Mathieu Arnold freebsd_committer 2018-05-15 06:36:05 UTC
Many parts in here are not where they belong. Can you please read [[ https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html | Chapter 15. Order of Variables in Port Makefiles ]] and correct your patch?
Comment 2 Mathieu Arnold freebsd_committer 2018-05-15 06:37:37 UTC
Also, please don't set GH_TAGNAME, use DISTVERSIONPREFIX.
Comment 3 Tobias Kortkamp freebsd_committer 2018-05-15 07:07:36 UTC
This completely breaks sndio support.  This change to patch-CMakeLists.txt
is wrong:

++    unset ( SNDIO_SUPPORT CACHE )
++    if ( enable-sndio )
++    pkg_check_modules ( SNDIO libsndio>=1.4.0 )
++    set ( SNDIO_SUPPORT ${SNDIO_FOUND} )
++    else ( enable-sndio )
++    unset_pkg_config ( SNDIO )
++    endif ( enable-sndio )

sndio doesn't come with a pkg-config file, so I'm not sure why this was
changed to use pkg_check_modules.  Please keep it like before.  This bit

-+unset ( SNDIO_SUPPORT CACHE )
-+if ( enable-sndio )
-+  set ( SNDIO_SUPPORT 1 )
-+endif ( enable-sndio )

needs to stay like it was.
Comment 4 takefu 2018-05-15 07:15:58 UTC
Created attachment 193417 [details]
fluidsynth-1.1.11.patch
Comment 5 takefu 2018-05-15 07:52:55 UTC
Created attachment 193418 [details]
fluidsynth-1.1.11.patch

portlint(1) was not running.
Comment 6 Thomas Zander freebsd_committer 2018-06-01 11:24:20 UTC
Patch looks good. Checking builds for dependent ports ...
Comment 7 commit-hook freebsd_committer 2018-06-01 21:44:38 UTC
A commit references this bug:

Author: riggs
Date: Fri Jun  1 21:44:34 UTC 2018
New revision: 471296
URL: https://svnweb.freebsd.org/changeset/ports/471296

Log:
  Updtate to upstrem version.

  PR:		228265
  Submitted by:	takefu@airport.fm
  Reviewed by:	riggs
  Approved by:	multimedia@ (riggs)

Changes:
  head/audio/fluidsynth/Makefile
  head/audio/fluidsynth/distinfo
  head/audio/fluidsynth/files/patch-CMakeLists.txt
  head/audio/fluidsynth/files/patch-src_drivers_fluid__adriver.c
  head/audio/fluidsynth/files/patch-src_drivers_fluid__alsa.c
  head/audio/fluidsynth/files/patch-src_drivers_fluid__oss.c
  head/audio/fluidsynth/pkg-plist
Comment 8 commit-hook freebsd_committer 2018-06-01 22:17:14 UTC
A commit references this bug:

Author: riggs
Date: Fri Jun  1 22:16:18 UTC 2018
New revision: 471300
URL: https://svnweb.freebsd.org/changeset/ports/471300

Log:
  Bump PORTREVISIONS to chase update to audio/fluidsynth 1.1.11

  PR:		228265

Changes:
  head/audio/alure/Makefile
  head/audio/bristol/Makefile
  head/audio/calf-lv2/Makefile
  head/audio/carla/Makefile
  head/audio/csound6/Makefile
  head/audio/denemo/Makefile
  head/audio/drumstick/Makefile
  head/audio/fluidplug-lv2/Makefile
  head/audio/fluidsynth-dssi/Makefile
  head/audio/gmsynth-lv2/Makefile
  head/audio/lmms/Makefile
  head/audio/musicpd/Makefile
  head/audio/openal-soft/Makefile
  head/audio/qsynth/Makefile
  head/audio/sdl2_mixer/Makefile
  head/audio/soundkonverter/Makefile
  head/audio/tuxguitar/Makefile
  head/games/doomsday/Makefile
  head/games/exult/Makefile
  head/games/gzdoom/Makefile
  head/games/scummvm/Makefile
  head/games/slade/Makefile
  head/games/stratagus/Makefile
  head/games/zdoom/Makefile
  head/multimedia/audacious-plugins/Makefile
  head/multimedia/audacious-plugins-gtk3/Makefile
  head/multimedia/gstreamer-plugins-buzztard/Makefile
  head/multimedia/vlc/Makefile