Bug 228278
| Summary: | [PATCH] graphics/leptonica: Update to 1.76.0, switch to github | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Peter Wullinger <freebsd> | ||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | fernape, hiroto.kagotani | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(hiroto.kagotani) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Peter Wullinger
2018-05-15 19:37:41 UTC
Take. Hi Peter, I applied the patch, but the port fails in the patch target. Is the patch under files/ still relevant? It doesn't seem to be anymore. Can you update your patch so it deletes files/ entirely? Also, the downloaded sources don't provide a configure script but a configure.ac. Could you try with USES=autoreconf? Cheers. Created attachment 193492 [details]
Updated patch with patch file deletion
Also remove files/patch-configure. Requires "patch -E"
Hi Fernando, (In reply to Fernando Apesteguía from comment #2) > I applied the patch but the port fails in the patch target. Yeah it would. Weird, I was sure that I did a successful poudriere build with this. Obviously not. > Is the patch under files/ still relevant? It doesn't seem to be anymore. No, the patch adds "openjpeg-2.3" include search path, which is now part of upstream's configure.ac > Can you update your patch so it deletes files/ entirely? I think "patch -E" can't do that, but I can get rid of files/patch-configure. > Also, the downloaded sources don't provide a configure script but a > configure.ac. Could you try with USES=autoreconf? USES=pkgconfig is also needed. Patched ports builds with in poudriere in 11.1-RELEASE-p10 jail. Side note: The build also conflicts with installed openjpeg15 (includes the wrong openjpeg.h), side-by-side installation is fine, though. There's also a bug that I could not yet track down wrt. installing bin/printimage, bin/printsplitimage, bin/printtiff, and bin/splitimage2pdf. These are built, but not installed. The trigger for this seems to be "--{en,dis}able-packages", but I cannot get those binaries to install. Created attachment 193496 [details]
patch to move to github and update to v1.76.0 (fixed patch #2)
Correct the pkg-plist errors and add USES=pkgconfig as it is needed.
(In reply to Peter Wullinger from comment #4) It seems it is deliberate. Those that you mention, along with other programs (like adaptmap_reg) are built but never installed since they are under the noinst_ prefix. Revision accepted: https://reviews.freebsd.org/D15478 Awaiting maintainer approval or timeout. A commit references this bug: Author: fernape Date: Fri Jun 1 15:30:58 UTC 2018 New revision: 471263 URL: https://svnweb.freebsd.org/changeset/ports/471263 Log: graphics/leptonica: update to 1.76.0 * switch to github * remove unnecessary patch file Committing after maintainer timeout (2 weeks) PR: 228278 Submitted by: freebsd@dhke.de Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D15478 Changes: head/graphics/leptonica/Makefile head/graphics/leptonica/distinfo head/graphics/leptonica/files/ head/graphics/leptonica/pkg-plist Committed, Thanks! |
