Bug 228306
| Summary: | [NEW PORT] games/genact: Nonsense activity generator | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mateusz Piotrowski <0mp> | ||||||||
| Component: | Individual Port(s) | Assignee: | Kirill Ponomarev <krion> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | jbeich, krion | ||||||||
| Priority: | --- | Keywords: | easy, feature, patch-ready | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://github.com/svenstaro/genact | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mateusz Piotrowski
2018-05-16 22:15:52 UTC
I realized that the install-strip target does not work. I'll submit a fix using STRIP_CMD instead in a moment. Created attachment 193480 [details]
Patch adding a new games/genact port (0.4.0, revision: 1)
Now the binary is stripped correctly.
Comment on attachment 193480 [details] Patch adding a new games/genact port (0.4.0, revision: 1) Looks OK i.e., "Reviewed by: jbeich" > + libc-0.2.36 \ libc < 0.2.38 may not be a good idea to use on 12.0-CURRENT. However, the port appears to work fine as is. See also ports r468993. https://github.com/rust-lang/libc/commit/969ad2b73cdc https://github.com/rust-lang/libc/commit/78f93220d70e (In reply to Mateusz Piotrowski from comment #0) > - I am not sure if I should set LICENSE to the license of genact > only or all the crates it depends on. Defining LICENSE for bundled libs is a good idea but if they change often it may complicate maintenance. In this case, all crates appear to have one style[1] of MIT license. bindgen has 3-clause BSD and its dependency libloading has different style[1] of MIT but given their code doesn't end up in genact binary FreeBSD package can probably omit their licenses. [1] https://fedoraproject.org/wiki/Licensing:MIT (In reply to Jan Beich from comment #3) > libloading has different style[1] of MIT Sorry, I keep confusing ISC with MIT. $ rg --no-line-number --no-filename -t toml license | sort -u license = "MIT" license = "Apache-2.0" <-- clang-sys, used by bindgen license = "Apache-2.0/MIT" license = "BSD-3-Clause" <-- bindgen, used by emscripten-sys license = "ISC" <-- libloading, used by clang-sys license = "MIT / Apache-2.0" license = "MIT" license = "MIT/Apache-2.0" license = "Unlicense/MIT" Created attachment 193484 [details] Patch adding a new games/genact port (0.4.0, revision: 2) (In reply to Jan Beich from comment #4) Thanks for the review and notes about libc. I'll keep that in mind in my future Rust ports. There's also `make cargo-crates-licenses | awk '{$1=""; print $0}' | sort --unique` which yields: Apache-2.0" Apache-2.0/MIT BSD-3-Clause ISC MIT MIT / Apache-2.0 MIT/Apache-2.0 Unlicense/MIT I updated the Makefile accordingly. A commit references this bug: Author: krion Date: Fri May 18 06:11:50 UTC 2018 New revision: 470270 URL: https://svnweb.freebsd.org/changeset/ports/470270 Log: Add games/genact: genact is a nonsense terminal activity generator. > Pretend to be busy or waiting for your computer when you should actually be > doing real work! Impress people with your insane multitasking skills. Just > open a few instances of genact and watch the show. genact has multiple scenes > that pretend to be doing something exciting or useful when in reality nothing > is happening at all. genact can load modules, which produce different activity. Currently, it comes with the following set of modules: bootlog, cargo, cc, composer, cryptomining, simcity, download, memdump, kernel_compile, weblog. WWW: https://github.com/svenstaro/genact PR: 228306 Submitted by: 0mp Inspired by: jbeich Changes: head/games/Makefile head/games/genact/ head/games/genact/Makefile head/games/genact/distinfo head/games/genact/files/ head/games/genact/files/patch-cargo-crates_pbr-1.0.0_src_tty_unix.rs head/games/genact/pkg-descr |