Bug 228307

Summary: Make dependency of devel/gvfs optional for a several different ports
Product: Ports & Packages Reporter: VVD <vvd>
Component: Individual Port(s)Assignee: freebsd-gnome mailing list <gnome>
Status: Open ---    
Severity: Affects Many People Keywords: needs-patch, needs-qa
Priority: --- Flags: bugzilla: maintainer-feedback? (gnome)
Version: Latest   
Hardware: Any   
OS: Any   

Description VVD 2018-05-16 23:15:54 UTC
gvfs is so annoying - always eat CPU from 1-2 to 20-30% from one core. But I don't use it.

I have installed ports with mandatory dependency from devel/gvfs:
x11-fm/nautilus
x11-toolkits/libgnomeui
graphics/evince
sysutils/brasero

But a simple hack remove the dependency:
diff -ur ports.orig/Mk/Uses/gnome.mk ports/Mk/Uses/gnome.mk
--- ports.orig/Mk/Uses/gnome.mk
+++ ports/Mk/Uses/gnome.mk
@@ -296,7 +296,7 @@
 librsvg2_USE_GNOME_IMPL=libgsf gdkpixbuf2 pango
 
 nautilus3_LIB_DEPENDS= libnautilus-extension.so:x11-fm/nautilus
-nautilus3_USE_GNOME_IMPL=gnomedesktop3 gvfs libxml2
+nautilus3_USE_GNOME_IMPL=gnomedesktop3 libxml2
 
 metacity_LIB_DEPENDS=  libmetacity-private.so:x11-wm/metacity
 
diff -ur ports.orig/x11-fm/nautilus/Makefile ports/x11-fm/nautilus/Makefile
--- ports.orig/x11-fm/nautilus/Makefile
+++ ports/x11-fm/nautilus/Makefile
@@ -20,7 +20,7 @@
 
 USES=          desktop-file-utils gettext gmake gnome libtool pathfix \
                pkgconfig tar:xz
-USE_GNOME=     intlhack gnomedesktop3 libxml2 gvfs introspection:build
+USE_GNOME=     intlhack gnomedesktop3 libxml2 introspection:build
 USE_LDCONFIG=  yes
 GNU_CONFIGURE= yes
 CPPFLAGS+=     -I${LOCALBASE}/include
diff -ur ports.orig/x11-toolkits/libgnomeui/Makefile ports/x11-toolkits/libgnomeui/Makefile
--- ports.orig/x11-toolkits/libgnomeui/Makefile
+++ ports/x11-toolkits/libgnomeui/Makefile
@@ -21,7 +21,7 @@
 RUN_DEPENDS=   ${LOCALBASE}/share/icons/gnome/index.theme:misc/gnome-icon-theme
 
 USES+=         bison gettext gmake localbase libtool:keepla pathfix pkgconfig
-USE_GNOME=     gnomeprefix intltool libbonoboui referencehack gvfs
+USE_GNOME=     gnomeprefix intltool libbonoboui referencehack
 USE_XORG=      sm
 USE_LDCONFIG=  yes
 GNU_CONFIGURE= yes
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-05-18 05:45:19 UTC
If gvfs is indeed optional (even with some functionality loss) for these ports, this change likely needs to take the form of creating a GVFS option and leaving it as a default enabled option (in OPTIONS_DEFAULT) as a couple of ports [1] already do, and adding in any explicit --enable/disable configure (or other build) options for the gvfs functionality.

sysutils/gigolo also unconditionazlly uses gvfs, but is potentially an OPTION'alisation candidate.

[1] graphics/gimp-app, audio/xmms2

Note: gnome@ is the maintainer for all ports referenced in this comment 0