Bug 228532

Summary: databases/neo4j: Various fixes and improvements
Product: Ports & Packages Reporter: Mateusz Piotrowski <0mp>
Component: Individual Port(s)Assignee: Wen Heping <wen>
Status: Open ---    
Severity: Affects Only Me CC: borjam, grahamperrin, jonathan, michael.osipov, w.schwarzenfeld, wen
Priority: --- Keywords: easy, feature
Version: LatestFlags: 0mp: maintainer-feedback?
grahamperrin: maintainer-feedback? (wen)
Hardware: Any   
OS: Any   
URL: https://www.freshports.org/databases/neo4j/
Bug Depends on:    
Bug Blocks: 268526, 228526    
Attachments:
Description Flags
Patch with various fixes and improvements for databases/neo4j 0mp: maintainer-approval?

Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-05-27 05:07:48 UTC 
Created attachment 193749 [details]
Patch with various fixes and improvements for databases/neo4j

Changes:
 * Bump PORTREVISION.
 * Describe licensing in more detail:
  * Add licenses of dependencies.
  * Define LICENSE_FILE*.
 * Silence MKDIR's.
 * Use "/bin/sh" instead of "/usr/bin/env bash" in the launch script. 
   It looks like there's no need to use Bash here.
 * Install bin/tools/* under ${PREFIX}/neo4j/lib instead of 
   ${PREFIX}/neo4j/libexec. This fixes the cypher-shell issue from 228526[1]. 
   I am not sure if this is a correct solution.

QA:
 * portlint -AC
 * manual testing on FreeBSD 12.0-CURRENT r333659 amd64
 * port test on FreeBSD 12.0-CURRENT r333659 amd64

[1]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228526
Comment 1 Walter Schwarzenfeld 2019-08-14 09:33:08 UTC 
Maintainer feedback, please!
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2023-01-02 20:56:35 UTC 
Triage: 

* bug 268526 comment 4 requests a review of this bug 228532 prior to 
  progress on 268526

* flag for feedback from the new maintainer of databases/neo4j

* clear the flag for feedback from the former maintainer

* the patch keyword is deprecated.
Comment 3 Borja Marcos 2023-01-18 10:52:23 UTC 
I´d like to add something.

This port runs as root, which is a Bad Idea™.

It´s simple to correct the rc script so that it accepts a username and group.

It´s also a good idea to offer some flexibility for choosing the JVM.

I have added these variables:


---
: ${neo4j_java_home:=/usr/local/openjdk11}
: ${neo4j_user:=neo4j}
: ${neo4j_group:=neo4j}
---

command should be:
---
command=/usr/local/bin/neo4j
command_args="start"
---

And for precmd,

---
        /usr/bin/install -d -o ${neo4j_user} -g ${neo4j_group} -m 755 ${NEO4J_LOGS}
        /usr/bin/install -d -o ${neo4j_user} -g ${neo4j_group} -m 755 ${NEO4J_RUN}
---
Comment 4 Borja Marcos 2023-01-18 11:18:27 UTC 
(In reply to Borja Marcos from comment #3)
Sorry, it needs the pid file fixed as well.

---
pidfile=/var/run/neo4j.pid
----

on prestart()

---
/usr/bin/install -o ${neo4j_user} -g ${neo4j_group} -m 755 /dev/null /var/run/neo4j.pid
---
Comment 5 Michael Osipov 2023-01-19 10:43:34 UTC 
Guys, please note https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268526
I hope I can address most of those issues.