Summary: | databases/neo4j: Various fixes and improvements | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Mateusz Piotrowski <0mp> | ||||
Component: | Individual Port(s) | Assignee: | Wen Heping <wen> | ||||
Status: | Open --- | ||||||
Severity: | Affects Only Me | CC: | borjam, grahamperrin, jonathan, michael.osipov, w.schwarzenfeld, wen | ||||
Priority: | --- | Keywords: | easy, feature | ||||
Version: | Latest | Flags: | 0mp:
maintainer-feedback?
grahamperrin: maintainer-feedback? (wen) |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://www.freshports.org/databases/neo4j/ | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 268526, 228526 | ||||||
Attachments: |
|
Description
Mateusz Piotrowski
2018-05-27 05:07:48 UTC
Maintainer feedback, please! Triage: * bug 268526 comment 4 requests a review of this bug 228532 prior to progress on 268526 * flag for feedback from the new maintainer of databases/neo4j * clear the flag for feedback from the former maintainer * the patch keyword is deprecated. I´d like to add something. This port runs as root, which is a Bad Idea™. It´s simple to correct the rc script so that it accepts a username and group. It´s also a good idea to offer some flexibility for choosing the JVM. I have added these variables: --- : ${neo4j_java_home:=/usr/local/openjdk11} : ${neo4j_user:=neo4j} : ${neo4j_group:=neo4j} --- command should be: --- command=/usr/local/bin/neo4j command_args="start" --- And for precmd, --- /usr/bin/install -d -o ${neo4j_user} -g ${neo4j_group} -m 755 ${NEO4J_LOGS} /usr/bin/install -d -o ${neo4j_user} -g ${neo4j_group} -m 755 ${NEO4J_RUN} --- (In reply to Borja Marcos from comment #3) Sorry, it needs the pid file fixed as well. --- pidfile=/var/run/neo4j.pid ---- on prestart() --- /usr/bin/install -o ${neo4j_user} -g ${neo4j_group} -m 755 /dev/null /var/run/neo4j.pid --- Guys, please note https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268526 I hope I can address most of those issues. |